refactor: add favoriteKey to llamma market

Author: 0xAlunara

apps/main/src/llamalend/features/market-list/LlamaMarketExpandedPanel.tsx

@@ -65,6 +65,7 @@ export const LlamaMarketExpandedPanel: ExpandedPanel<LlamaMarket> = ({ row: { or
   const { data: deposited, error: depositedError } = useUserMarketStats(market, LlamaMarketColumnId.UserDeposited)
   const {
     controllerAddress,
+    favoriteKey,
     assets,
     leverage,
     liquidityUsd,
@@ -98,7 +99,7 @@ export const LlamaMarketExpandedPanel: ExpandedPanel<LlamaMarket> = ({ row: { or
                     confirmationText={t`Market address copied`}
                     data-testid={`copy-market-address-${controllerAddress}`}
                   />
-                  <FavoriteMarketButton address={controllerAddress} />
+                  <FavoriteMarketButton address={favoriteKey} />
                 </Stack>
               </Stack>
             }

apps/main/src/llamalend/features/market-list/cells/MarketTitleCell/MarketBadges.tsx

@@ -25,7 +25,7 @@ const poolTypeTooltips: Record<LlamaMarketType, () => string> = {
 
 /** Displays badges for a pool, such as the chain icon and the pool type. */
 export const MarketBadges = ({ market, isMobile }: { market: LlamaMarket; isMobile: boolean }) => {
-  const { controllerAddress, type, leverage, deprecatedMessage } = market
+  const { favoriteKey, type, leverage, deprecatedMessage } = market
   const isSmall = useMediaQuery('(max-width:1250px)')
   const { isCollateralEroded } = useUserMarketStats(market)?.data ?? {}
   return (
@@ -68,7 +68,7 @@ export const MarketBadges = ({ market, isMobile }: { market: LlamaMarket; isMobi
         </Tooltip>
       )}
 
-      <FavoriteMarketButton address={controllerAddress} desktopOnly />
+      <FavoriteMarketButton address={favoriteKey} desktopOnly />
     </Stack>
   )
 }

apps/main/src/llamalend/queries/market-list/llama-markets.ts

@@ -69,6 +69,7 @@ export type LlamaMarket = {
   deprecatedMessage: string | null
   userHasPositions: Record<MarketRateType, boolean> | null // null means no positions in either market and makes easy to filter
   createdAt: number
+  favoriteKey: Address // this differs per market type; for lend markets the vault address, for mint markets the amm address
 }
 
 export type LlamaMarketsResult = {
@@ -242,6 +243,7 @@ const convertLendingVault = (
           }
         : null,
     createdAt: new Date(createdAt).getTime(),
+    favoriteKey: vault,
   }
 }
 
@@ -327,6 +329,7 @@ const convertMintMarket = (
     leverage,
     userHasPositions: hasBorrow ? { [MarketRateType.Borrow]: hasBorrow, [MarketRateType.Supply]: false } : null,
     createdAt: new Date(createdAt).getTime(),
+    favoriteKey: llamma,
   }
 }