Suggestions and Improvements

[ArchBlood]

Hello and good evening;

I like the module very much after testing it out for the first time, here are some ideas that could improve it.

1. Depending on the user, the content can vary on time and could timeout as well, in this case I believe it would be best to configure a set time limit as well as an exception in case of a timeout.
2. Not all content is moved, meaning comments and replies remain owned by the original content owner and is still lost during profile deletion.
3. In the case where a profile is being deleted at the same time as the content being moved, there should be an exception preventing the profile from being deleted while the content moving is in queue, otherwise the queue should be cancelled if this can't be prevented.

Hope that you have a good rest of your day.

Your friends at @GreenMeteor

[marc-farre]

Thanks a lot for these advises! I'll have a look to them as soon as possible.
I planned to propose the module to the marketplace for free, so anybody can send PR to make the module better!
And FYI: https://github.com/cuzy-app/humhub-modules-move-content/blob/main/docs/TODOS.md

[marc-farre]

@ArchBlood https://github.com/cuzy-app/humhub-modules-move-content/releases/tag/1.0.1
And https://github.com/cuzy-app/humhub-modules-move-content/releases/tag/1.0.2 for Humhub 1.13

[ArchBlood]

Looking over the changes it seems that the checkbox is off

Sample

https://github.com/cuzy-app/humhub-modules-move-content/blob/4016d8889ae22aba937bc9e13ca86ce6cf896a49/views/user/index.php#L22-L31

Slight Fix

<div class="container-fluid">
    <div class="panel-heading"><?= $title ?></div>
    <div class="panel-body">
        <?php $form = ActiveForm::begin(['id' => 'move-content']); ?>
        <div class="form-group">
            <?= $form->field($model, 'sourceUserGuid')->widget(UserPickerField::class); ?>
            <?= $form->field($model, 'targetUserGuid')->widget(UserPickerField::class); ?>
            <?= $form->field($model, 'moveProfileContent')->checkbox(); ?>
        </div>
        <div class="form-group">
            <?= Button::save()->submit(); ?>
        </div>
        <?php ActiveForm::end(); ?>
    </div>
</div>

[marc-farre]

Thanks for informing me.
This is strange. What theme are you using? With Humhub native theme and Humhub 1.12 it's okay for me:

Fields are already in form-group:

[ArchBlood]

Thanks for informing me. This is strange. What theme are you using? With Humhub native theme and Humhub 1.12 it's okay for me:

Fields are already in form-group:

Looks to be an issue with the updater module not clearing the cache after updating, after manually clearing it seems to be working correctly in the beta version again.