Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

Conversation

@adriah
Copy link
Member

@adriah adriah commented Jan 10, 2019

Added fields for GDPR in member model. Please have a look 😄

@adriah adriah requested review from henrist and matsasc January 10, 2019 12:34
Copy link
Member

@henrist henrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Also needs a rebase if we will go forward with this.

"uio_username": null,
"user": null
"user": null,
"gdpr_approval": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation, see also other lines

migrations.AddField(
model_name='member',
name='last_edited_by',
name='gdpr_approval',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be changed

uio_username = models.CharField(max_length=15, null=True, blank=True)
comments = models.TextField(null=True, blank=True)
last_edited_by = models.ForeignKey(User, related_name='modifier', null=True)
gdpr_approval = models.BooleanField(default=False, help_text='Privacy policy agreement')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antakeligvis bedre om vi hadde brukt en dato her, slik at man kan forstå når det skjedde.

Har vi egentlig noen policy liggende noe sted?

Viser forøvrig til diskusjon på Slack: https://cybernetisk.slack.com/archives/C03QDK7CV/p1547123717047400
Det ble aldri konkludert med hva som var det reelle behovet, og om det faktisk er nødvendig med samtykke. Og det fremkommer f.eks. ikke hva man i så fall samtykker til, og hvordan evt. samtykke kan trekkes tilbake og hva slags betydning det får.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants