chore: refactoring into smaller files

Author: bahmutov

__snapshots__/commit-message-install-spec.js

@@ -6,35 +6,6 @@ exports['commit-message-install gets commit message for specific commit returns
 message body
 `
 
-exports['commit-message-install getInstallJson sets properties and all platforms 1'] = {
-  "platform": "*",
-  "env": {
-    "foo": 42
-  },
-  "packages": "debug"
-}
-
-exports['commit-message-install getInstallJson sets given platform 1'] = {
-  "platform": "linux",
-  "env": {
-    "foo": 42
-  },
-  "packages": "debug"
-}
-
-exports['commit-message-install getInstallJson sets several modules 1'] = {
-  "platform": "linux",
-  "env": {},
-  "packages": "debug chalk"
-}
-
-exports['commit-message-install getInstallJson sets branch 1'] = {
-  "platform": "linux",
-  "env": {},
-  "packages": "debug chalk",
-  "branch": "test-branch"
-}
-
 exports['commit-message-install isPlatformAllowed compares platforms isPlatformAllowed 1'] = {
   "name": "isPlatformAllowed",
   "behavior": [
@@ -131,7 +102,7 @@ exports['commit-message-install getJsonBlock returns json with branch 1'] = {
   "branch": "test-branch"
 }
 
-exports['commit-message-install getJsonFromGit returns undefined without valid block 1'] = {
+exports['commit-message-install getJsonFromGit extracts the json from git message 1'] = {
   "platform": "win32",
   "branch": "some-branch"
 }

__snapshots__/get-install-json-spec.js

@@ -0,0 +1,28 @@
+exports['getInstallJson sets properties and all platforms 1'] = {
+  "platform": "*",
+  "env": {
+    "foo": 42
+  },
+  "packages": "debug"
+}
+
+exports['getInstallJson sets given platform 1'] = {
+  "platform": "linux",
+  "env": {
+    "foo": 42
+  },
+  "packages": "debug"
+}
+
+exports['getInstallJson sets several modules 1'] = {
+  "platform": "linux",
+  "env": {},
+  "packages": "debug chalk"
+}
+
+exports['getInstallJson sets branch 1'] = {
+  "platform": "linux",
+  "env": {},
+  "packages": "debug chalk",
+  "branch": "test-branch"
+}

src/commit-message-install-spec.js

@@ -86,26 +86,6 @@ describe('commit-message-install', () => {
     })
   })
 
-  context('getInstallJson', () => {
-    const getInstallJson = require('.').getInstallJson
-
-    it('sets properties and all platforms', () => {
-      snapshot(getInstallJson('debug', { foo: 42 }, '*'))
-    })
-
-    it('sets given platform', () => {
-      snapshot(getInstallJson('debug', { foo: 42 }, 'linux'))
-    })
-
-    it('sets several modules', () => {
-      snapshot(getInstallJson(['debug', 'chalk'], {}, 'linux'))
-    })
-
-    it('sets branch', () => {
-      snapshot(getInstallJson(['debug', 'chalk'], {}, 'linux', 'test-branch'))
-    })
-  })
-
   context('isPlatformAllowed', () => {
     const isPlatformAllowed = require('.').isPlatformAllowed
 

src/get-install-json-spec.js

@@ -0,0 +1,30 @@
+'use strict'
+
+/* eslint-env mocha */
+const la = require('lazy-ass')
+const is = require('check-more-types')
+const snapshot = require('snap-shot-it')
+
+describe('getInstallJson', () => {
+  const getInstallJson = require('.').getInstallJson
+
+  it('is a function', () => {
+    la(is.fn(getInstallJson))
+  })
+
+  it('sets properties and all platforms', () => {
+    snapshot(getInstallJson('debug', { foo: 42 }, '*'))
+  })
+
+  it('sets given platform', () => {
+    snapshot(getInstallJson('debug', { foo: 42 }, 'linux'))
+  })
+
+  it('sets several modules', () => {
+    snapshot(getInstallJson(['debug', 'chalk'], {}, 'linux'))
+  })
+
+  it('sets branch', () => {
+    snapshot(getInstallJson(['debug', 'chalk'], {}, 'linux', 'test-branch'))
+  })
+})

src/get-install-json.js

@@ -0,0 +1,47 @@
+const la = require('lazy-ass')
+const is = require('check-more-types')
+const os = require('os')
+const debug = require('debug')('commit-message-install')
+const { isNpmInstall } = require('./utils')
+
+// forms JSON object that can be parsed later
+function getInstallJson (packages, env, platform, branch) {
+  if (!env) {
+    env = {}
+  }
+  if (!platform) {
+    platform = os.platform()
+  }
+  la(
+    is.unemptyString(packages) || is.strings(packages),
+    'invalid package / list of packages',
+    packages
+  )
+  la(is.object(env), 'invalid env object', env)
+  if (is.strings(packages)) {
+    packages = packages.join(' ')
+  }
+  la(is.unemptyString(platform), 'missing platform', platform)
+
+  const json = {
+    platform,
+    env,
+    packages
+  }
+  if (branch) {
+    la(is.unemptyString(branch), 'invalid branch name', branch)
+    debug('branch name', branch)
+    json.branch = branch
+  }
+
+  la(
+    isNpmInstall(json),
+    'formed invalid json object',
+    json,
+    'from arguments',
+    arguments
+  )
+  return json
+}
+
+module.exports = getInstallJson

src/index.js

@@ -6,6 +6,8 @@ const is = require('check-more-types')
 const os = require('os')
 const execa = require('execa')
 const chalk = require('chalk')
+const getInstallJson = require('./get-install-json')
+const { isNpmInstall } = require('./utils')
 
 const prop = name => object => object[name]
 
@@ -72,13 +74,6 @@ function getJsonBlock (message) {
   }
 }
 
-// to install multiple packages, use comma-separated list
-const isNpmInstall = is.schema({
-  platform: is.maybe.unemptyString,
-  env: is.maybe.object,
-  packages: is.unemptyString
-})
-
 const isRunIf = is.schema({
   platform: is.maybe.unemptyString,
   env: is.maybe.object
@@ -171,46 +166,6 @@ function npmInstall (json) {
   })
 }
 
-// forms JSON object that can be parsed later
-function getInstallJson (packages, env, platform, branch) {
-  if (!env) {
-    env = {}
-  }
-  if (!platform) {
-    platform = os.platform()
-  }
-  la(
-    is.unemptyString(packages) || is.strings(packages),
-    'invalid package / list of packages',
-    packages
-  )
-  la(is.object(env), 'invalid env object', env)
-  if (is.strings(packages)) {
-    packages = packages.join(' ')
-  }
-  la(is.unemptyString(platform), 'missing platform', platform)
-
-  const json = {
-    platform,
-    env,
-    packages
-  }
-  if (branch) {
-    la(is.unemptyString(branch), 'invalid branch name', branch)
-    debug('branch name', branch)
-    json.branch = branch
-  }
-
-  la(
-    isNpmInstall(json),
-    'formed invalid json object',
-    json,
-    'from arguments',
-    arguments
-  )
-  return json
-}
-
 // looks at the current Git message,
 // extracts JSON block
 function getJsonFromGit () {

src/utils.js

@@ -0,0 +1,12 @@
+const is = require('check-more-types')
+
+// to install multiple packages, use comma-separated list
+const isNpmInstall = is.schema({
+  platform: is.maybe.unemptyString,
+  env: is.maybe.object,
+  packages: is.unemptyString
+})
+
+module.exports = {
+  isNpmInstall
+}