-
Notifications
You must be signed in to change notification settings - Fork 15
Add otherIdentifiers to Dandiset model
#361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 97.89% 97.91% +0.01%
==========================================
Files 18 18
Lines 2377 2398 +21
==========================================
+ Hits 2327 2348 +21
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
536f69c to
523c5d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an otherIdentifiers field to the Dandiset model to store alternative Dandiset identifiers used in other DANDI instances. The field is marked as read-only and server-managed.
Changes:
- Extracted
DANDISET_IDENTIFIER_PATTERNconstant for reusability - Updated existing
identifierfield to use the new pattern constant - Added
otherIdentifiersfield as a list of strings with pattern validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
523c5d6 to
d34c40c
Compare
|
@candleindark I've opened a new pull request, #362, to work on those changes. Once the pull request is ready, I'll request review from you. |
So that the metadata can be used amount different tests
66b324f to
813b8d9
Compare
This PR closes #358.
This PR define the
otherIdentifiersfield in theDandisetmodel. It is a list of alternative Dandiset identifiers of a given Dandiset used identifying the Dandiset in other DANDI instances.Note: The field provides the following extra JSON
"readOnly"set totrueas it should only be set by the server(s)."nskey"set to"dandi"as this property is particular to DANDI.