Skip to content

Conversation

@candleindark
Copy link
Member

@candleindark candleindark commented Jan 12, 2026

This PR closes #358.

This PR define the otherIdentifiers field in the Dandiset model. It is a list of alternative Dandiset identifiers of a given Dandiset used identifying the Dandiset in other DANDI instances.

Note: The field provides the following extra JSON

  • "readOnly" set to true as it should only be set by the server(s).
  • "nskey" set to "dandi" as this property is particular to DANDI.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.91%. Comparing base (cabfa3d) to head (498cdac).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   97.89%   97.91%   +0.01%     
==========================================
  Files          18       18              
  Lines        2377     2398      +21     
==========================================
+ Hits         2327     2348      +21     
  Misses         50       50              
Flag Coverage Δ
unittests 97.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark candleindark added patch Increment the patch version when merged enhancement New feature or request labels Jan 12, 2026
@candleindark candleindark force-pushed the other-identifiers branch 2 times, most recently from 536f69c to 523c5d6 Compare January 13, 2026 02:33
@candleindark candleindark requested a review from Copilot January 13, 2026 02:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an otherIdentifiers field to the Dandiset model to store alternative Dandiset identifiers used in other DANDI instances. The field is marked as read-only and server-managed.

Changes:

  • Extracted DANDISET_IDENTIFIER_PATTERN constant for reusability
  • Updated existing identifier field to use the new pattern constant
  • Added otherIdentifiers field as a list of strings with pattern validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Jan 13, 2026

@candleindark I've opened a new pull request, #362, to work on those changes. Once the pull request is ready, I'll request review from you.

So that the metadata can be
used amount different tests
@candleindark candleindark self-assigned this Jan 13, 2026
@candleindark candleindark marked this pull request as ready for review January 13, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add otherIdentifiers to Dandiset model

2 participants