Add sameAs field to the Dandiset model`
#364
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 97.89% 97.91% +0.01%
==========================================
Files 18 18
Lines 2379 2401 +22
==========================================
+ Hits 2329 2351 +22
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Defines a new sameAs field on the Dandiset model to represent DANDI URIs pointing to the same dandiset on other DANDI instances (per #358 / replaces #361).
Changes:
- Added
sameAs(optional list) to theDandisetmodel with JSON schema metadata. - Refactored existing publishing-metadata test to reuse a shared
base_dandiset_metadatafixture. - Added tests covering
sameAsbehavior for omitted/empty/valid/invalid inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dandischema/models.py |
Adds the new sameAs field to the Dandiset schema. |
dandischema/tests/test_models.py |
Introduces a shared metadata fixture and adds coverage for sameAs validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
candleindark
force-pushed
the
add-sameas
branch
from
91e2e75 to
853efb6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
So that the metadata can be reused in different tests without modifications from a previous test
candleindark
force-pushed
the
add-sameas
branch
2 times, most recently
from
96d486c to
419313b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR closes #358 and replaces #361.
This PR defines the
sameAsfield in theDandisetmodel. It is a list of DANDI URLs of the Dandiset at other DANDI instances. It implements the solution proposed by #358 (comment).