Force annotations onto their own lines for block expressions and parameter clauses

[daniel-trinh]

Annotations for expressions in blocks and parameter clauses currently are placed on the same line:

def asdf(
  @annotation one: Int,
  @a @b(c) two: String
)

class A extends B {
  @SomeImportantAnnotation(param = true) override val param: Int = 1

  @NotSoImportantAnnotation(param = false) val description: String = "Not so important"
}

Instead, it should be formatted as..

def asdf(
  @annotation 
  one: Int,
  @a 
  @b(c) 
  two: String
)

class A extends B {
  @SomeImportantAnnotation(param = true) 
  override val param: Int = 1

  @NotSoImportantAnnotation(param = false) 
  val description: String = "Not so important"
}

This would most likely only affect parameters that are already placed on their own line, so
something like this wouldn't be affected:

def asdf(@annotation one: Int, @a @b(c) two: String)

stays as..

def asdf(@annotation one: Int, @a @b(c) two: String)

Implementation details note: this needs to be implemented without breaking the AlignParameters feature

See here for similar issue on original branch: scala-ide#91

[bambuchaAdm]

Don't you think here

def asdf(
  @annotation 
  one: Int,
  @a @b(c) 
  two: String
)

better construction will be set second annotation @b(c) to next line ?

[daniel-trinh]

Yea, good catch, I'll fix the description

[bambuchaAdm]

Test for annotation are green. Maybe tommorrow, I will clean up tests. I think it will be quick.

[bambuchaAdm]

On making tests green, i ran into test for scala-ide#28.

Maybe we should introduce configuration parameter ?

[daniel-trinh]

Hmm, I think we should either keep it as is (force annotations onto their own line), or modify it so that it preserves newlines implicitly.

I'm not a fan of more configuration parameters, because there are much more interesting problems to solve than thinking about how to format Scala code -- having one reasonable default is good enough IMO.

[daniel-trinh]

@bambuchaAdm How's this feature looking? Scala 2.11 release is nearing, #4 and #12 are pretty useful features to try and include into a 0.15.0 non-snapshot release.

[ConnorDoyle]

I would love to see this change in scalariform. Without this fix, we have some lines that exceed 160 columns!

[patrikvarga]

+1, this is very annoying, especially that it is not conforming the Scala Style Guide and thus makes the following statement in the documentation invalid:
"Scalariform is compatible with the Scala Style Guide in the sense that, given the right preference settings, source code that is initially compiliant with the Style Guide will not become uncompliant after formatting."

[kiritsuku]

This issue was moved to scala-ide#185