Skip to content

fix: Use proper file permissions in INSTALL.ts for Linux/WSL #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m4nt0de4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use proper file permissions in INSTALL.ts for Linux/WSL #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Releases/v2.5/.claude/INSTALL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async function promptChoice(question: string, choices: string[], defaultIdx = 0)
}

// ============================================================================
// PERMISSIONS (chmod → chown → chmod)
// PERMISSIONS (chown → chmod dirs → chmod files → chmod scripts)
// ============================================================================

function fixPermissions(targetDir: string): void {
Expand All @@ -114,25 +114,25 @@ function fixPermissions(targetDir: string): void {
print(`${c.gray}─────────────────────────────────────────────────${c.reset}`);

try {
// Step 1: chmod first - make files accessible
execSync(`chmod -R 755 "${targetDir}"`, { stdio: 'pipe' });
printSuccess('Step 1: chmod -R 755 (make accessible)');

// Step 2: chown - change ownership to current user
// Step 1: chown - change ownership to current user
execSync(`chown -R ${info.uid}:${info.gid} "${targetDir}"`, { stdio: 'pipe' });
printSuccess(`Step 2: chown -R to ${info.username}`);
printSuccess(`Ownership set to ${info.username} (${info.uid}:${info.gid})`);

// Step 2: directories get rwxr-x--- (750)
execSync(`find "${targetDir}" -type d -exec chmod 750 {} +`, { stdio: 'pipe' });
printSuccess('Directories set to 750 (rwxr-x---)');

// Step 3: chmod again - set final permissions
execSync(`chmod -R 755 "${targetDir}"`, { stdio: 'pipe' });
printSuccess('Step 3: chmod -R 755 (final permissions)');
// Step 3: regular files get rw-r----- (640)
execSync(`find "${targetDir}" -type f -exec chmod 640 {} +`, { stdio: 'pipe' });
printSuccess('Files set to 640 (rw-r-----)');

// Make scripts executable
for (const pattern of ['*.ts', '*.sh', '*.hook.ts']) {
// Step 4: scripts get rwxr-x--- (750)
for (const pattern of ['*.ts', '*.sh', '*.py']) {
try {
execSync(`find "${targetDir}" -name "${pattern}" -exec chmod 755 {} \\;`, { stdio: 'pipe' });
execSync(`find "${targetDir}" -type f -name "${pattern}" -exec chmod 750 {} +`, { stdio: 'pipe' });
} catch (e) { /* ignore */ }
}
printSuccess('Set executable permissions on scripts');
printSuccess('Scripts (.ts, .sh, .py) set to 750 (rwxr-x---)');

} catch (err: any) {
printError(`Permission fix failed: ${err.message}`);
Expand Down