Skip to content

Commit 1a226cb

Browse files
firewavefirewave
authored
fixed #12021 - bail out on compiler warnings in CI (#7735)
1 parent 6a962e3 commit 1a226cb

15 files changed

+38
-41
lines changed

‎.github/workflows/CI-cygwin.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
# Cygwin will always link the binaries even if they already exist. The linking is also extremely slow. So just run the "check" target which includes all the binaries.
5151
- name: Build all and run test
5252
run: |
53-
C:\cygwin\bin\bash.exe -l -c cd %GITHUB_WORKSPACE% && make VERBOSE=1 -j%NUMBER_OF_PROCESSORS% check
53+
C:\cygwin\bin\bash.exe -l -c cd %GITHUB_WORKSPACE% && make VERBOSE=1 -j%NUMBER_OF_PROCESSORS% CXXOPTS="-Werror" check
5454
5555
- name: Extra test for misra
5656
run: |

‎.github/workflows/CI-mingw.yml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,24 +53,23 @@ jobs:
5353
with:
5454
key: ${{ github.workflow }}-${{ github.job }}-${{ matrix.os }}
5555

56-
# TODO: bail out on warning
5756
- name: Build cppcheck
5857
run: |
5958
export PATH="/mingw64/lib/ccache/bin:$PATH"
6059
# set RDYNAMIC to work around broken MinGW detection
6160
# use lld for faster linking
62-
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) cppcheck
61+
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) CXXOPTS="-Werror" cppcheck
6362
6463
- name: Build test
6564
run: |
6665
export PATH="/mingw64/lib/ccache/bin:$PATH"
6766
# set RDYNAMIC to work around broken MinGW detection
6867
# use lld for faster linking
69-
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) testrunner
68+
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) CXXOPTS="-Werror" testrunner
7069
7170
- name: Run test
7271
run: |
7372
export PATH="/mingw64/lib/ccache/bin:$PATH"
7473
# set RDYNAMIC to work around broken MinGW detection
7574
# use lld for faster linking
76-
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) check
75+
make VERBOSE=1 RDYNAMIC=-lshlwapi LDOPTS=-fuse-ld=lld -j$(nproc) CXXOPTS="-Werror" check

‎.github/workflows/CI-unixish-docker.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ jobs:
6565
run: |
6666
mkdir cmake.output
6767
cd cmake.output
68-
cmake -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache ..
68+
cmake -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache ..
6969
cmake --build . -- -j$(nproc)
7070
7171
- name: CMake build (with GUI)
7272
if: matrix.build_gui
7373
run: |
74-
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
74+
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
7575
cmake --build cmake.output -- -j$(nproc)
7676
7777
- name: Run CMake test
@@ -111,12 +111,12 @@ jobs:
111111
- name: Build cppcheck
112112
run: |
113113
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
114-
make -j$(nproc) HAVE_RULES=yes CXXOPTS="-w"
114+
make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror"
115115
116116
- name: Build test
117117
run: |
118118
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
119-
make -j$(nproc) HAVE_RULES=yes CXXOPTS="-w" testrunner
119+
make -j$(nproc) HAVE_RULES=yes CXXOPTS="-Werror" testrunner
120120
121121
- name: Run test
122122
run: |

‎.github/workflows/CI-unixish.yml‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ jobs:
5858
- name: CMake build on ubuntu (with GUI / system tinyxml2)
5959
if: contains(matrix.os, 'ubuntu')
6060
run: |
61-
cmake -S . -B cmake.output.tinyxml2 -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_BUNDLED_TINYXML2=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
61+
cmake -S . -B cmake.output.tinyxml2 -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_BUNDLED_TINYXML2=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
6262
cmake --build cmake.output.tinyxml2 -- -j$(nproc)
6363
6464
- name: CMake build on macos (with GUI / system tinyxml2)
6565
if: contains(matrix.os, 'macos')
6666
run: |
67-
cmake -S . -B cmake.output.tinyxml2 -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_BUNDLED_TINYXML2=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DQt6_DIR=$(brew --prefix qt@6)/lib/cmake/Qt6
67+
cmake -S . -B cmake.output.tinyxml2 -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_BUNDLED_TINYXML2=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DQt6_DIR=$(brew --prefix qt@6)/lib/cmake/Qt6
6868
cmake --build cmake.output.tinyxml2 -- -j$(nproc)
6969
7070
- name: Run CMake test (system tinyxml2)
@@ -127,12 +127,12 @@ jobs:
127127
- name: Run CMake on ubuntu (with GUI)
128128
if: contains(matrix.os, 'ubuntu')
129129
run: |
130-
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install
130+
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install
131131
132132
- name: Run CMake on macos (with GUI)
133133
if: contains(matrix.os, 'macos')
134134
run: |
135-
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DQt6_DIR=$(brew --prefix qt@6)/lib/cmake/Qt6
135+
cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DQt6_DIR=$(brew --prefix qt@6)/lib/cmake/Qt6
136136
137137
- name: Run CMake build
138138
run: |
@@ -219,7 +219,7 @@ jobs:
219219
- name: Build with Unsigned char
220220
run: |
221221
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
222-
make -j$(nproc) CXXOPTS=-funsigned-char testrunner
222+
make -j$(nproc) CXXOPTS="-Werror -funsigned-char" testrunner
223223
224224
- name: Test with Unsigned char
225225
run: |
@@ -253,11 +253,11 @@ jobs:
253253
- name: Build with TEST_MATHLIB_VALUE
254254
run: |
255255
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
256-
make -j$(nproc) CPPOPTS=-DTEST_MATHLIB_VALUE all
256+
make -j$(nproc) CXXOPTS="-Werror" CPPOPTS=-DTEST_MATHLIB_VALUE all
257257
258258
- name: Test with TEST_MATHLIB_VALUE
259259
run: |
260-
make -j$(nproc) CPPOPTS=-DTEST_MATHLIB_VALUE check
260+
make -j$(nproc) check
261261
262262
check_nonneg:
263263

@@ -281,7 +281,7 @@ jobs:
281281
282282
- name: Check syntax with NONNEG
283283
run: |
284-
make check-nonneg
284+
make check-nonneg CXXOPTS="-Werror"
285285
286286
build_cmake_boost:
287287

@@ -337,7 +337,7 @@ jobs:
337337
338338
- name: Run CMake on macOS (with Boost)
339339
run: |
340-
cmake -S . -B cmake.output.boost -G "Unix Makefiles" -DBUILD_TESTS=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
340+
cmake -S . -B cmake.output.boost -G "Unix Makefiles" -DBUILD_TESTS=On -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
341341
grep -q '\-DHAVE_BOOST' ./cmake.output.boost/compile_commands.json
342342
343343
- name: Build with CMake on macOS (with Boost)
@@ -412,12 +412,12 @@ jobs:
412412
- name: Build cppcheck
413413
run: |
414414
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
415-
make -j$(nproc) HAVE_RULES=yes
415+
make -j$(nproc) CXXOPTS="-Werror" HAVE_RULES=yes
416416
417417
- name: Build test
418418
run: |
419419
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
420-
make -j$(nproc) HAVE_RULES=yes testrunner
420+
make -j$(nproc) CXXOPTS="-Werror" HAVE_RULES=yes testrunner
421421
422422
- name: Run test
423423
run: |
@@ -497,7 +497,7 @@ jobs:
497497
498498
- name: Test Signalhandler
499499
run: |
500-
cmake -S . -B build.cmake.signal -G "Unix Makefiles" -DBUILD_TESTS=On
500+
cmake -S . -B build.cmake.signal -G "Unix Makefiles" -DBUILD_TESTS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On
501501
cmake --build build.cmake.signal --target test-signalhandler -- -j$(nproc)
502502
# TODO: how to run this without copying the file?
503503
cp build.cmake.signal/bin/test-s* .
@@ -508,7 +508,7 @@ jobs:
508508
- name: Test Stacktrace
509509
if: contains(matrix.os, 'ubuntu')
510510
run: |
511-
cmake -S . -B build.cmake.stack -G "Unix Makefiles" -DBUILD_TESTS=On
511+
cmake -S . -B build.cmake.stack -G "Unix Makefiles" -DBUILD_TESTS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On
512512
cmake --build build.cmake.stack --target test-stacktrace -- -j$(nproc)
513513
# TODO: how to run this without copying the file?
514514
cp build.cmake.stack/bin/test-s* .
@@ -609,7 +609,7 @@ jobs:
609609
run: |
610610
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
611611
# compile with verification and ast matchers
612-
make -j$(nproc) CXXOPTS="-g -O2 -w" CPPOPTS="-DCHECK_INTERNAL -DHAVE_BOOST" MATCHCOMPILER=yes VERIFY=1
612+
make -j$(nproc) CXXOPTS="-Werror -g -O2" CPPOPTS="-DCHECK_INTERNAL -DHAVE_BOOST" MATCHCOMPILER=yes VERIFY=1
613613
614614
- name: CMake
615615
run: |

‎.github/workflows/CI-windows.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
run: |
5656
rem TODO: enable rules?
5757
rem specify Release build so matchcompiler is used
58-
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install || exit /b !errorlevel!
58+
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
5959
6060
- name: Build GUI release
6161
run: |
@@ -125,7 +125,7 @@ jobs:
125125
7z x pcre-%PCRE_VERSION%.zip || exit /b !errorlevel!
126126
cd pcre-%PCRE_VERSION% || exit /b !errorlevel!
127127
git apply --ignore-space-change ..\externals\pcre.patch || exit /b !errorlevel!
128-
cmake . -G "NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DPCRE_BUILD_PCRECPP=Off -DPCRE_BUILD_TESTS=Off -DPCRE_BUILD_PCREGREP=Off -DCMAKE_POLICY_VERSION_MINIMUM=3.5 || exit /b !errorlevel!
128+
cmake . -G "NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DPCRE_BUILD_PCRECPP=Off -DPCRE_BUILD_TESTS=Off -DPCRE_BUILD_PCREGREP=Off -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
129129
nmake || exit /b !errorlevel!
130130
copy pcre.h ..\externals || exit /b !errorlevel!
131131
copy pcre.lib ..\externals\pcre64.lib || exit /b !errorlevel!
@@ -207,7 +207,7 @@ jobs:
207207
- name: Test SEH wrapper
208208
if: matrix.config == 'release'
209209
run: |
210-
cmake -S . -B build.cmake.seh -DBUILD_TESTS=On || exit /b !errorlevel!
210+
cmake -S . -B build.cmake.seh -DBUILD_TESTS=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
211211
cmake --build build.cmake.seh --target test-sehwrapper || exit /b !errorlevel!
212212
:: TODO: how to run this without copying the file?
213213
copy build.cmake.seh\bin\Debug\test-sehwrapper.exe . || exit /b !errorlevel!

‎.github/workflows/asan.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,9 @@ jobs:
7171
python3 -m pip install pytest-xdist
7272
python3 -m pip install psutil
7373
74-
# TODO: disable all warnings
7574
- name: CMake
7675
run: |
77-
cmake -S . -B cmake.output -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_MATCHCOMPILER=Verify -DANALYZE_ADDRESS=On -DENABLE_CHECK_INTERNAL=On -DUSE_BOOST=On -DCPPCHK_GLIBCXX_DEBUG=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_GLOBAL_AUTOGEN_TARGET=On -DDISABLE_DMAKE=On -DFILESDIR= -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
76+
cmake -S . -B cmake.output -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DUSE_MATCHCOMPILER=Verify -DANALYZE_ADDRESS=On -DENABLE_CHECK_INTERNAL=On -DUSE_BOOST=On -DCPPCHK_GLIBCXX_DEBUG=Off -DCMAKE_DISABLE_PRECOMPILE_HEADERS=On -DCMAKE_GLOBAL_AUTOGEN_TARGET=On -DDISABLE_DMAKE=On -DFILESDIR= -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
7877
env:
7978
CC: clang-21
8079
CXX: clang++-21

‎.github/workflows/codeql-analysis.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
- name: Build cppcheck
4747
if: matrix.language == 'cpp'
4848
run: |
49-
make -j$(nproc) HAVE_RULES=yes CPPCHK_GLIBCXX_DEBUG= cppcheck
49+
make -j$(nproc) CXXOPTS="-Werror" HAVE_RULES=yes CPPCHK_GLIBCXX_DEBUG= cppcheck
5050
5151
- name: Perform CodeQL Analysis
5252
uses: github/codeql-action/analyze@v3

‎.github/workflows/coverage.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Compile instrumented
4444
run: |
4545
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
46-
make -j$(nproc) CXXOPTS="-g -fprofile-arcs -ftest-coverage" HAVE_RULES=yes CPPCHK_GLIBCXX_DEBUG= all
46+
make -j$(nproc) CXXOPTS="-Werror -g -fprofile-arcs -ftest-coverage" HAVE_RULES=yes CPPCHK_GLIBCXX_DEBUG= all
4747
4848
- name: Run instrumented tests
4949
run: |

‎.github/workflows/cppcheck-premium.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
tar xzvf cppcheckpremium.tar.gz
5050
mv cppcheckpremium-devdrop-20250713 cppcheckpremium
5151
# Overwrite cppcheck binary
52-
make -j$(nproc) CXXOPTS=-O2 MATCHCOMPILER=yes
52+
make -j$(nproc) CXXOPTS="-Werror -O2" MATCHCOMPILER=yes
5353
cp cppcheck cppcheckpremium/
5454
5555
- name: Generate a license file

‎.github/workflows/release-windows.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
7z x pcre-%PCRE_VERSION%.zip || exit /b !errorlevel!
4848
cd pcre-%PCRE_VERSION% || exit /b !errorlevel!
4949
git apply --ignore-space-change ..\externals\pcre.patch || exit /b !errorlevel!
50-
cmake . -G "Visual Studio 17 2022" -A x64 -DPCRE_BUILD_PCRECPP=OFF -DPCRE_BUILD_PCREGREP=OFF -DPCRE_BUILD_TESTS=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5 || exit /b !errorlevel!
50+
cmake . -G "Visual Studio 17 2022" -A x64 -DPCRE_BUILD_PCRECPP=OFF -DPCRE_BUILD_PCREGREP=OFF -DPCRE_BUILD_TESTS=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
5151
msbuild -m PCRE.sln -p:Configuration=Release -p:Platform=x64 || exit /b !errorlevel!
5252
copy pcre.h ..\externals || exit /b !errorlevel!
5353
copy Release\pcre.lib ..\externals\pcre64.lib || exit /b !errorlevel!
@@ -68,7 +68,7 @@ jobs:
6868
run: |
6969
:: TODO: enable rules?
7070
:: specify Release build so matchcompiler is used
71-
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_ONLINE_HELP=On || exit /b !errorlevel!
71+
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_ONLINE_HELP=On -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
7272
cmake --build build --target cppcheck-gui --config Release || exit /b !errorlevel!
7373
7474
# TODO: package PDBs

0 commit comments

Comments
 (0)