Make ofstreams thow exception on write issues

Author: samopolacek

cli/cppcheckexecutor.cpp

@@ -267,6 +267,7 @@ int CppCheckExecutor::check_internal(CppCheck& cppcheck)
 
     if (!settings.outputFile.empty()) {
         mErrorOutput = new std::ofstream(settings.outputFile);
+        mErrorOutput->exceptions(std::ios_base::failbit | std::ios_base::badbit);
     }
 
     if (settings.xml) {

gui/checkthread.cpp

@@ -77,6 +77,7 @@ static bool executeCommand(std::string exe, std::vector<std::string> args, std::
 
     if (redirect.compare(0,3,"2> ") == 0) {
         std::ofstream fout(redirect.substr(3));
+        fout->exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout << process.readAllStandardError().toStdString();
     }
     return process.exitCode() == 0;

lib/analyzerinfo.cpp

@@ -50,6 +50,7 @@ void AnalyzerInformation::writeFilesTxt(const std::string &buildDir, const std::
 
     const std::string filesTxt(buildDir + "/files.txt");
     std::ofstream fout(filesTxt);
+    fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     for (const std::string &f : sourcefiles) {
         const std::string afile = getFilename(f);
         fout << afile << ".a" << (++fileCount[afile]) << "::" << Path::simplifyPath(Path::fromNativeSeparators(f)) << '\n';

lib/cppcheck.cpp

@@ -281,6 +281,7 @@ static void createDumpFile(const Settings& settings,
 
     {
         std::ofstream fout(getCtuInfoFileName(dumpFile));
+        fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     }
 
     std::string language;
@@ -505,6 +506,7 @@ unsigned int CppCheck::check(const std::string &path)
         const std::string redirect2 = analyzerInfo.empty() ? std::string("2>&1") : ("2> " + clangStderr);
         if (!mSettings.buildDir.empty()) {
             std::ofstream fout(clangcmd);
+            fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout << exe << " " << args2 << " " << redirect2 << std::endl;
         } else if (mSettings.verbose && !mSettings.quiet) {
             mErrorLogger.reportOut(exe + " " + args2);
@@ -536,6 +538,7 @@ unsigned int CppCheck::check(const std::string &path)
 
         if (!mSettings.buildDir.empty()) {
             std::ofstream fout(clangAst);
+            fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout << output2 << std::endl;
         }
 
@@ -555,6 +558,7 @@ unsigned int CppCheck::check(const std::string &path)
 
             // create dumpfile
             std::ofstream fdump;
+            fdump.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             std::string dumpFile;
             createDumpFile(mSettings, path, fdump, dumpFile);
             if (fdump.is_open()) {
@@ -773,6 +777,7 @@ unsigned int CppCheck::checkFile(const std::string& filename, const std::string
 
         // write dump file xml prolog
         std::ofstream fdump;
+        fdump.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         std::string dumpFile;
         createDumpFile(mSettings, filename, fdump, dumpFile);
         if (fdump.is_open()) {
@@ -1423,6 +1428,7 @@ void CppCheck::executeAddons(const std::vector<std::string>& files)
     if (files.size() >= 2 || endsWith(files[0], ".ctu-info")) {
         fileList = Path::getPathFromFilename(files[0]) + FILELIST;
         std::ofstream fout(fileList);
+        fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         for (const std::string& f: files)
             fout << f << std::endl;
     }
@@ -1682,6 +1688,7 @@ void CppCheck::analyseClangTidy(const ImportProject::FileSettings &fileSettings)
     if (!mSettings.buildDir.empty()) {
         const std::string analyzerInfoFile = AnalyzerInformation::getAnalyzerInfoFile(mSettings.buildDir, fileSettings.filename, emptyString);
         std::ofstream fcmd(analyzerInfoFile + ".clang-tidy-cmd");
+        fcmd.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fcmd << istr.str();
     }
 

lib/summaries.cpp

@@ -87,6 +87,7 @@ std::string Summaries::create(const Tokenizer *tokenizer, const std::string &cfg
         if (pos != std::string::npos) {
             filename[pos+1] = 's';
             std::ofstream fout(filename);
+            fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
             fout << ostr.str();
         }
     }

test/helpers.cpp

@@ -55,8 +55,7 @@ ScopedFile::ScopedFile(std::string name, const std::string &content, std::string
     }
 
     std::ofstream of(mFullPath);
-    if (!of.is_open())
-        throw std::runtime_error("ScopedFile(" + mFullPath + ") - could not open file");
+    of.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     of << content;
 }
 

tools/dmake.cpp

@@ -216,6 +216,7 @@ static int write_vcxproj(const std::string &proj_name, const std::function<void(
 
     // treat as binary to prevent implicit line ending conversions
     std::ofstream out(proj_name, std::ios::binary|std::ios::trunc);
+    out.exceptions(std::ios_base::failbit | std::ios_base::badbit);
     out << outstr;
 
     return EXIT_SUCCESS;
@@ -395,6 +396,7 @@ int main(int argc, char **argv)
     // QMAKE - lib/lib.pri
     {
         std::ofstream fout1("lib/lib.pri");
+        fout1.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         if (fout1.is_open()) {
             fout1 << "# no manual edits - this file is autogenerated by dmake\n\n";
             fout1 << "include($$PWD/pcrerules.pri)\n";
@@ -418,12 +420,7 @@ int main(int argc, char **argv)
 
     static const char makefile[] = "Makefile";
     std::ofstream fout(makefile, std::ios_base::trunc);
-    if (!fout.is_open()) {
-        std::cerr << "An error occurred while trying to open "
-                  << makefile
-                  << ".\n";
-        return EXIT_FAILURE;
-    }
+    fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
 
     fout << "# This file is generated by tools/dmake, do not edit.\n\n";