suppress checkersReport in unusedFunction selfchecks / add special handling in UNUSEDFUNCTION_ONLY hack

firewave · firewave · commit 7f51cf8295e4 · 2025-11-01T16:05:57.000+01:00
diff --git a/.selfcheck_unused_suppressions b/.selfcheck_unused_suppressions
@@ -1,3 +1,6 @@
+# should not be reported - see #13387
+checkersReport
+
 # we are not using all methods of their interfaces
 unusedFunction:externals/*/*
 
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
@@ -352,7 +352,8 @@ bool CppCheckExecutor::reportUnmatchedSuppressions(const Settings &settings, con
     // ignore all other suppressions if we use the unusedFunction hack
     for (auto&& s : suppr)
     {
-        if (doUnusedFunctionOnly && s.errorId != "unusedFunction")
+        // TODO: checkersReport should not be reported - see #13387
+        if (doUnusedFunctionOnly && s.errorId != "unusedFunction" && s.errorId != "checkersReport")
             continue;
         supprlist.addSuppression(std::move(s));
     }

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,8 @@ bool CppCheckExecutor::reportUnmatchedSuppressions(const Settings &settings, con`
`352`	`352`	`// ignore all other suppressions if we use the unusedFunction hack`
`353`	`353`	`for (auto&& s : suppr)`
`354`	`354`	`{`
`355`		`- if (doUnusedFunctionOnly && s.errorId != "unusedFunction")`
	`355`	`+ // TODO: checkersReport should not be reported - see #13387`
	`356`	`+ if (doUnusedFunctionOnly && s.errorId != "unusedFunction" && s.errorId != "checkersReport")`
`356`	`357`	`continue;`
`357`	`358`	`supprlist.addSuppression(std::move(s));`
`358`	`359`	`}`