aseert ofstream good() after close()

Author: samopolacek

cli/cppcheckexecutor.cpp

@@ -80,6 +80,7 @@ CppCheckExecutor::~CppCheckExecutor()
         try
         {
             mErrorOutput->close();
+            assert(mErrorOutput->good());
         }
         catch (const std::ios_base::failure&)
         {

gui/checkthread.cpp

@@ -76,11 +76,13 @@ static bool executeCommand(std::string exe, std::vector<std::string> args, std::
         output = process.readAllStandardOutput().toStdString();
 
     if (redirect.compare(0,3,"2> ") == 0) {
-        std::ofstream fout();
+        std::ofstream fout;
         fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout.open(redirect.substr(3));
         assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
         fout << process.readAllStandardError().toStdString();
+        fout.close();
+        assert(fout.good());
     }
     return process.exitCode() == 0;
 }

lib/analyzerinfo.cpp

@@ -80,13 +80,17 @@ void AnalyzerInformation::writeFilesTxt(const std::string &buildDir, const std::
         const std::string afile = getFilename(fs.filename);
         fout << afile << ".a" << (++fileCount[afile]) << ":" << fs.cfg << ":" << Path::simplifyPath(Path::fromNativeSeparators(fs.filename)) << std::endl;
     }
+
+    assert(fout.good());
 }
 
 void AnalyzerInformation::close()
 {
     if (mOutputStream.is_open()) {
         mOutputStream << "</analyzerinfo>\n";
+
         mOutputStream.close();
+        assert(mOutputStream.good());
     }
 }
 

lib/cppcheck.cpp

@@ -288,6 +288,8 @@ static void createDumpFile(const Settings& settings,
         fout.exceptions(std::ios_base::failbit | std::ios_base::badbit);
         fout.open(getCtuInfoFileName(dumpFile));
         assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
+        fout.close();
+        assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
     }
 
     std::string language;
@@ -421,6 +423,7 @@ CppCheck::~CppCheck()
         try
         {
             mPlistFile.close();
+            assert(mPlistFile.good()); // If we ever disable exceptions, catch issues ASAP
         }
         catch (const std::ios_base::failure&)
         {
@@ -528,6 +531,8 @@ unsigned int CppCheck::check(const std::string &path)
             fout.open(clangcmd);
             assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
             fout << exe << " " << args2 << " " << redirect2 << std::endl;
+            fout.close();
+            assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
         } else if (mSettings.verbose && !mSettings.quiet) {
             mErrorLogger.reportOut(exe + " " + args2);
         }
@@ -562,6 +567,8 @@ unsigned int CppCheck::check(const std::string &path)
             fout.open(clangAst);
             assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
             fout << output2 << std::endl;
+            fout.close();
+            assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
         }
 
         try {
@@ -595,6 +602,7 @@ unsigned int CppCheck::check(const std::string &path)
                 fdump << "</dump>" << std::endl;
                 fdump << "</dumps>" << std::endl;
                 fdump.close();
+                assert(fdump.good()); // If we ever disable exceptions, catch issues ASAP
             }
 
             // run addons
@@ -690,7 +698,9 @@ unsigned int CppCheck::checkFile(const std::string& filename, const std::string
 
     if (mPlistFile.is_open()) {
         mPlistFile << ErrorLogger::plistFooter();
+
         mPlistFile.close();
+        assert(mPlistFile.good()); // If we ever disable exceptions, catch issues ASAP
     }
 
     CheckUnusedFunctions checkUnusedFunctions(nullptr, nullptr, nullptr);
@@ -1031,6 +1041,7 @@ unsigned int CppCheck::checkFile(const std::string& filename, const std::string
         if (fdump.is_open()) {
             fdump << "</dumps>" << std::endl;
             fdump.close();
+            assert(fdump.good()); // If we ever disable exceptions, catch issues ASAP
         }
 
         executeAddons(dumpFile);
@@ -1459,6 +1470,9 @@ void CppCheck::executeAddons(const std::vector<std::string>& files)
 
         for (const std::string& f: files)
             fout << f << std::endl;
+        
+        fout.close();
+        assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
     }
 
     for (const std::string &addon : mSettings.addons) {
@@ -1722,6 +1736,9 @@ void CppCheck::analyseClangTidy(const ImportProject::FileSettings &fileSettings)
         assert(fcmd.is_open()); // If we ever disable exceptions, catch issues ASAP
 
         fcmd << istr.str();
+        
+        fcmd.close();
+        assert(fcmd.good()); // If we ever disable exceptions, catch issues ASAP
     }
 
     while (std::getline(istr, line)) {

lib/summaries.cpp

@@ -92,6 +92,9 @@ std::string Summaries::create(const Tokenizer *tokenizer, const std::string &cfg
             assert(fout.is_open()); // If we ever disable exceptions, catch issues ASAP
 
             fout << ostr.str();
+            
+            fout.close();
+            assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
         }
     }
 

test/helpers.cpp

@@ -60,6 +60,9 @@ ScopedFile::ScopedFile(std::string name, const std::string &content, std::string
     assert(of.is_open()); // If we ever disable exceptions, catch issues ASAP
 
     of << content;
+    
+    of.close();
+    assert(of.good()); // If we ever disable exceptions, catch issues ASAP
 }
 
 ScopedFile::~ScopedFile() {

tools/dmake.cpp

@@ -223,6 +223,9 @@ static int write_vcxproj(const std::string &proj_name, const std::function<void(
 
     out << outstr;
 
+    out.close();
+    assert(out.good()); // If we ever disable exceptions, catch issues ASAP
+
     return EXIT_SUCCESS;
 }
 
@@ -421,6 +424,9 @@ int main(int argc, char **argv)
                 fout1 << " \\\n" << std::string(11, ' ');
         }
         fout1 << "\n";
+        
+        fout1.close();
+        assert(fout1.good()); // If we ever disable exceptions, catch issues ASAP
     }
 
     static const char makefile[] = "Makefile";
@@ -762,5 +768,9 @@ int main(int argc, char **argv)
     compilefiles(fout, extfiles, emptyString);
     compilefiles(fout, toolsfiles, "${INCLUDE_FOR_LIB}");
 
+
+    fout.close();
+    assert(fout.good()); // If we ever disable exceptions, catch issues ASAP
+
     return 0;
 }