prefer inline suppressions in selfchecks

other_test.py: adjusted `test_unmatched_file` for Windows

fixed #14249 - XML suppression parsing did not simplify the file name

fixed #14248 - suppressions with subpath not reported as unmatched

other_test.py: added test for reporting unmatched suppressions with subpath

Author: firewave

.selfcheck_suppressions

@@ -2,24 +2,6 @@ missingIncludeSystem
 # should not be reported - see #13387
 checkersReport
 
-# temporary suppressions - fix the warnings!
-simplifyUsing:lib/valueptr.h
-naming-privateMemberVariable:gui/test/cppchecklibrarydata/testcppchecklibrarydata.h
-bitwiseOnBoolean:lib/library.cpp
-templateInstantiation:lib/checkunusedfunctions.cpp
-templateInstantiation:lib/errorlogger.cpp
-templateInstantiation:lib/liobrary.cpp
-shadowFunction:lib/checkbufferoverrun.cpp
-shadowFunction:lib/checkclass.cpp
-shadowFunction:lib/checknullpointer.cpp
-shadowFunction:lib/cppcheck.cpp
-shadowFunction:lib/fwdanalysis.cpp
-shadowFunction:lib/library.cpp
-shadowFunction:lib/symboldatabase.cpp
-shadowFunction:lib/templatesimplifier.cpp
-shadowFunction:lib/token.cpp
-shadowFunction:tools/triage/mainwindow.cpp
-
 # warnings in Qt generated code we cannot fix
 funcArgNamesDifferent:*/moc_checkthread.cpp
 funcArgNamesDifferent:*/moc_codeeditstylecontrols.cpp

gui/test/cppchecklibrarydata/testcppchecklibrarydata.h

@@ -48,9 +48,13 @@ private slots:
     static void loadCfgFile(const QString &filename, CppcheckLibraryData &data, QString &res, bool removeFile = false);
     static void saveCfgFile(const QString &filename, CppcheckLibraryData &data);
 
+    // cppcheck-suppress naming-privateMemberVariable - TODO: fix this
     CppcheckLibraryData libraryData;
+    // cppcheck-suppress naming-privateMemberVariable - TODO: fix this
     CppcheckLibraryData fileLibraryData;
+    // cppcheck-suppress naming-privateMemberVariable - TODO: fix this
     QString result;
 
+    // cppcheck-suppress naming-privateMemberVariable - TODO: fix this
     static const QString TempCfgFile;
 };

lib/suppressions.cpp

@@ -129,7 +129,7 @@ std::string SuppressionList::parseXmlFile(const char *filename)
             if (std::strcmp(name, "id") == 0)
                 s.errorId = text;
             else if (std::strcmp(name, "fileName") == 0)
-                s.fileName = text;
+                s.fileName = Path::simplifyPath(text);
             else if (std::strcmp(name, "lineNumber") == 0)
                 s.lineNumber = strToInt<int>(text);
             else if (std::strcmp(name, "symbolName") == 0)
@@ -549,7 +549,7 @@ std::list<SuppressionList::Suppression> SuppressionList::getUnmatchedLocalSuppre
             continue;
         if (s.errorId == ID_CHECKERSREPORT)
             continue;
-        if (!s.isLocal() || s.fileName != file.spath())
+        if (!s.isLocal() || !PathMatch::match(s.fileName, file.spath()))
             continue;
         result.push_back(s);
     }

lib/valueptr.h

@@ -37,6 +37,7 @@ class CPPCHECKLIB ValuePtr {
 public:
     using pointer = T*;
     using element_type = T;
+    // cppcheck-suppress simplifyUsing - TODO: fix this
     using cloner_type = decltype(&cloner<T>::apply);
 
     ValuePtr() : mPtr(nullptr), mClone() {}

test/cli/other_test.py

@@ -3797,4 +3797,60 @@ def test_premium_disabled_unmatched(tmp_path):  #13663
         'nofile:0:0: information: Unmatched suppression: uninitvar [unmatchedSuppression]'
     ]
     assert stdout == ''
-    assert ret == 0, stdout
+    assert ret == 0, stdout
+
+
+def test_unmatched_file(tmp_path):  # #14248 / #14249
+    lib_path = tmp_path / 'lib'
+    os.makedirs(lib_path)
+
+    test_file = lib_path / 'test.c'
+    with open(test_file, "w"):
+        pass
+
+    suppr_txt = tmp_path / 'suppr.txt'
+    with open(suppr_txt, "w") as f:
+        f.write('''
+error:lib/test.c
+error2:lib\\test.c
+''')
+
+    suppr_xml = tmp_path / 'suppr.xml'
+    with open(suppr_xml, "w") as f:
+        f.write('''
+<suppressions>
+    <suppress>
+        <id>error3</id>
+        <fileName>lib/test.c</fileName>
+    </suppress>
+    <suppress>
+        <id>error4</id>
+        <fileName>lib\\test.c</fileName>
+    </suppress>
+</suppressions>
+''')
+
+    args = [
+        '-q',
+        '--template=simple',
+        '--enable=information',
+        f'--suppressions-list={suppr_txt}',
+        f'--suppress-xml={suppr_xml}',
+        '--suppress=error5:lib/test.c',
+        '--suppress=error6:lib\\test.c',
+        str(test_file)
+    ]
+
+    lib_file = 'lib' + os.path.sep + 'test.c'
+
+    ret, stdout, stderr = cppcheck(args)
+    assert stdout == ''
+    assert stderr.splitlines() == [
+        f'{lib_file}:-1:0: information: Unmatched suppression: error [unmatchedSuppression]',
+        f'{lib_file}:-1:0: information: Unmatched suppression: error2 [unmatchedSuppression]',
+        f'{lib_file}:-1:0: information: Unmatched suppression: error3 [unmatchedSuppression]',
+        f'{lib_file}:-1:0: information: Unmatched suppression: error4 [unmatchedSuppression]',
+        f'{lib_file}:-1:0: information: Unmatched suppression: error5 [unmatchedSuppression]',
+        f'{lib_file}:-1:0: information: Unmatched suppression: error6 [unmatchedSuppression]'
+    ]
+    assert ret == 0, stdout