Skip to content

Commit ec11793

Browse files
authored
testrunner: pass buffers to simplecpp::TokenList() without size parameter (#7899)
1 parent c0a066d commit ec11793

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

test/testcppcheck.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
#include <algorithm>
3434
#include <cstdlib>
3535
#include <list>
36-
#include <sstream>
3736
#include <string>
3837
#include <unordered_set>
3938
#include <utility>
@@ -487,9 +486,8 @@ class TestCppcheck : public TestFixture {
487486
"y\n"
488487
";\n";
489488

490-
std::istringstream fin(code);
491489
simplecpp::OutputList outputList;
492-
const simplecpp::TokenList tokens2(fin, files, "", &outputList);
490+
const simplecpp::TokenList tokens2(code, files, "", &outputList);
493491
const std::string expected2 = " <rawtokens>\n"
494492
" <file index=\"0\" name=\"test.c\"/>\n"
495493
" <file index=\"1\" name=\"\"/>\n"
@@ -532,8 +530,8 @@ class TestCppcheck : public TestFixture {
532530

533531
std::vector<std::string> files;
534532

535-
std::istringstream istr("void f();\nint x;\n");
536-
const simplecpp::TokenList tokens(istr, files, "m1.c");
533+
const char code[] = "void f();\nint x;\n";
534+
const simplecpp::TokenList tokens(code, files, "m1.c");
537535

538536
Preprocessor preprocessor(settings, errorLogger, Standards::Language::C);
539537
ASSERT(preprocessor.loadFiles(tokens, files));

test/testpreprocessor.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class TestPreprocessor : public TestFixture {
5353
std::string expandMacros(const char (&code)[size], ErrorLogger &errorLogger) const {
5454
simplecpp::OutputList outputList;
5555
std::vector<std::string> files;
56-
const simplecpp::TokenList tokens1 = simplecpp::TokenList(code, size-1, files, "file.cpp", &outputList);
56+
const simplecpp::TokenList tokens1 = simplecpp::TokenList(code, files, "file.cpp", &outputList);
5757
Preprocessor p(settingsDefault, errorLogger, Path::identify(tokens1.getFiles()[0], false));
5858
simplecpp::TokenList tokens2 = p.preprocess(tokens1, "", files, true);
5959
p.reportOutput(outputList, true);
@@ -69,7 +69,7 @@ class TestPreprocessor : public TestFixture {
6969
if (tokenlist.front())
7070
throw std::runtime_error("token list not empty");
7171

72-
const simplecpp::TokenList tokens1(code, size-1, files, file0);
72+
const simplecpp::TokenList tokens1(code, files, file0);
7373

7474
// Preprocess..
7575
simplecpp::TokenList tokens2(files);
@@ -85,7 +85,7 @@ class TestPreprocessor : public TestFixture {
8585
std::vector<RemarkComment> getRemarkComments(const char (&code)[size], ErrorLogger& errorLogger) const
8686
{
8787
std::vector<std::string> files;
88-
const simplecpp::TokenList tokens1(code, size-1, files, "test.cpp");
88+
const simplecpp::TokenList tokens1(code, files, "test.cpp");
8989

9090
const Preprocessor preprocessor(settingsDefault, errorLogger, Path::identify(tokens1.getFiles()[0], false));
9191
return preprocessor.getRemarkComments(tokens1);
@@ -365,7 +365,7 @@ class TestPreprocessor : public TestFixture {
365365
settings.userUndefs.insert(arg+2);
366366
std::vector<std::string> files;
367367
// TODO: this adds an empty filename
368-
simplecpp::TokenList tokens(code,size-1,files);
368+
simplecpp::TokenList tokens(code,files);
369369
tokens.removeComments();
370370
Preprocessor preprocessor(settings, *this, Standards::Language::C); // TODO: do we need to consider #file?
371371
const std::set<std::string> configs = preprocessor.getConfigs(tokens);
@@ -379,7 +379,7 @@ class TestPreprocessor : public TestFixture {
379379
std::size_t getHash(const char (&code)[size]) {
380380
std::vector<std::string> files;
381381
// TODO: this adds an empty filename
382-
simplecpp::TokenList tokens(code,size-1,files);
382+
simplecpp::TokenList tokens(code,files);
383383
tokens.removeComments();
384384
Preprocessor preprocessor(settingsDefault, *this, Standards::Language::C); // TODO: do we need to consider #file?
385385
return preprocessor.calculateHash(tokens, "");
@@ -534,7 +534,7 @@ class TestPreprocessor : public TestFixture {
534534
"2\n"
535535
"#endif\n";
536536
std::vector<std::string> files;
537-
simplecpp::TokenList tokens(filedata, sizeof(filedata), files, "test.c");
537+
simplecpp::TokenList tokens(filedata, files, "test.c");
538538

539539
// preprocess code with unix32 platform..
540540
{

test/testtokenize.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ class TestTokenizer : public TestFixture {
579579
void directiveDump(const char (&code)[size], const char filename[], const Settings& settings, std::ostream& ostr) {
580580
simplecpp::OutputList outputList;
581581
std::vector<std::string> files;
582-
const simplecpp::TokenList tokens1(code, size-1, files, filename, &outputList);
582+
const simplecpp::TokenList tokens1(code, files, filename, &outputList);
583583
Preprocessor preprocessor(settings, *this, Path::identify(tokens1.getFiles()[0], false));
584584
std::list<Directive> directives = preprocessor.createDirectives(tokens1);
585585

test/testtokenlist.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class TestTokenList : public TestFixture {
156156
// TokenList::determineCppC() because there are no tokens
157157
const char code[] = "#include <sys/poll.h>";
158158
std::vector<std::string> files;
159-
simplecpp::TokenList tokens1(code, sizeof(code), files, "poll.h", nullptr);
159+
simplecpp::TokenList tokens1(code, files, "poll.h", nullptr);
160160
Preprocessor preprocessor(settingsDefault, *this, Path::identify(tokens1.getFiles()[0], false));
161161
simplecpp::TokenList tokensP = preprocessor.preprocess(tokens1, "", files, true);
162162
TokenList tokenlist(settingsDefault, Standards::Language::C); // headers are treated as C files

0 commit comments

Comments
 (0)