aligned Settings::library and Settings::libraries in tests / added TODOs

Author: firewave

test/testautovariables.cpp

@@ -52,6 +52,7 @@ class TestAutoVariables : public TestFixture {
         settings.severity.enable(Severity::style);
         LOAD_LIB_2(settings.library, "std.cfg");
         LOAD_LIB_2(settings.library, "qt.cfg");
+        settings.libraries.emplace_back("qt");
 
         TEST_CASE(testautovar1);
         TEST_CASE(testautovar2);

test/testbufferoverrun.cpp

@@ -5488,6 +5488,7 @@ class TestBufferOverrun : public TestFixture {
 
         Settings settings;
         LOAD_LIB_2(settings.library, "posix.cfg");
+        settings.libraries.emplace_back("posix");
 
         check("void f(){\n"
               "int pipefd[1];\n" // <--  array of two integers is needed

test/testcondition.cpp

@@ -49,6 +49,7 @@ class TestCondition : public TestFixture {
         PLATFORM(settings1, cppcheck::Platform::Native);
 
         LOAD_LIB_2(settings0.library, "qt.cfg");
+        settings0.libraries.emplace_back("qt");
         LOAD_LIB_2(settings0.library, "std.cfg");
 
         settings0.severity.enable(Severity::style);

test/testconstructors.cpp

@@ -1952,7 +1952,8 @@ class TestConstructors : public TestFixture {
 
     void initvar_smartptr() { // #10237
         Settings s;
-        s.libraries.emplace_back("std");
+        // TODO: test shuld probably not pass without library
+        //LOAD_LIB_2(s.library, "std.cfg");
         check("struct S {\n"
               "    explicit S(const std::shared_ptr<S>& sp) {\n"
               "        set(*sp);\n"
@@ -3589,7 +3590,9 @@ class TestConstructors : public TestFixture {
 
     void uninitVarInheritClassInit() {
         Settings s;
-        s.libraries.emplace_back("vcl");
+        // TODO: test should probably not pass without library
+        //LOAD_LIB_2(s.library, "vcl.cfg");
+        //s.libraries.emplace_back("vcl");
 
         check("class Fred: public TObject\n"
               "{\n"

test/testfunctions.cpp

@@ -43,11 +43,11 @@ class TestFunctions : public TestFixture {
         settings.severity.enable(Severity::performance);
         settings.severity.enable(Severity::portability);
         settings.certainty.enable(Certainty::inconclusive);
-        settings.libraries.emplace_back("posix");
         settings.standards.c = Standards::C11;
         settings.standards.cpp = Standards::CPP11;
         LOAD_LIB_2(settings.library, "std.cfg");
         LOAD_LIB_2(settings.library, "posix.cfg");
+        settings.libraries.emplace_back("posix");
 
         // Prohibited functions
         TEST_CASE(prohibitedFunctions_posix);

test/testio.cpp

@@ -39,6 +39,7 @@ class TestIO : public TestFixture {
         LOAD_LIB_2(settings.library, "std.cfg");
         LOAD_LIB_2(settings.library, "windows.cfg");
         LOAD_LIB_2(settings.library, "qt.cfg");
+        settings.libraries.emplace_back("qt");
 
         TEST_CASE(coutCerrMisusage);
 

test/testleakautovar.cpp

@@ -472,6 +472,7 @@ class TestLeakAutoVar : public TestFixture {
     void assign23() {
         Settings s = settings;
         LOAD_LIB_2(settings.library, "posix.cfg");
+        settings.libraries.emplace_back("posix");
         check("void f() {\n"
               "    int n1, n2, n3, n4, n5, n6, n7, n8, n9, n10, n11, n12, n13, n14;\n"
               "    *&n1 = open(\"xx.log\", O_RDONLY);\n"
@@ -1852,6 +1853,7 @@ class TestLeakAutoVar : public TestFixture {
         Settings s;
         LOAD_LIB_2(s.library, "std.cfg");
         LOAD_LIB_2(s.library, "posix.cfg");
+        s.libraries.emplace_back("posix");
 
         check("void f() {\n"
               "    char* temp = strdup(\"temp.txt\");\n"

test/testmemleak.cpp

@@ -151,6 +151,7 @@ class TestMemleakInFunction : public TestFixture {
     void run() override {
         LOAD_LIB_2(settings1.library, "std.cfg");
         LOAD_LIB_2(settings1.library, "posix.cfg");
+        settings1.libraries.emplace_back("posix");
         LOAD_LIB_2(settings2.library, "std.cfg");
 
         TEST_CASE(realloc1);
@@ -1705,6 +1706,7 @@ class TestMemleakStructMember : public TestFixture {
     void run() override {
         LOAD_LIB_2(settings.library, "std.cfg");
         LOAD_LIB_2(settings.library, "posix.cfg");
+        settings.libraries.emplace_back("posix");
 
         // testing that errors are detected
         TEST_CASE(err);
@@ -2291,11 +2293,11 @@ class TestMemleakNoVar : public TestFixture {
 
     void run() override {
         settings.certainty.setEnabled(Certainty::inconclusive, true);
-        settings.libraries.emplace_back("posix");
         settings.severity.enable(Severity::warning);
 
         LOAD_LIB_2(settings.library, "std.cfg");
         LOAD_LIB_2(settings.library, "posix.cfg");
+        settings.libraries.emplace_back("posix");
 
         // pass allocated memory to function..
         TEST_CASE(functionParameter);

test/testtokenize.cpp

@@ -58,8 +58,11 @@ class TestTokenizer : public TestFixture {
         settings_windows.checkUnusedTemplates = true;
 
         // library=qt
+        LOAD_LIB_2(settings0.library, "qt.cfg");
         settings0.libraries.emplace_back("qt");
+        LOAD_LIB_2(settings1.library, "qt.cfg");
         settings1.libraries.emplace_back("qt");
+        LOAD_LIB_2(settings2.library, "qt.cfg");
         settings2.libraries.emplace_back("qt");
 
         TEST_CASE(tokenize1);