-
Notifications
You must be signed in to change notification settings - Fork 5
feat: document popups for interactions with a blockchain (DAP-4800) [DO NOT MERGE] #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ni-2
wants to merge
5
commits into
develop
Choose a base branch
from
dap-4800
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and modal-confirm-document
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-06 09:43:51 CET |
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 90 days! |
alsakhaev
requested changes
Apr 30, 2025
Comment on lines
+133
to
+162
| // mutationToPublish.source = EntitySourceType.Origin // save to the contract | ||
| // if (mode === ModalMode.Forking) { | ||
| // mutationToPublish.metadata.fork_of = mutationToPublish.id | ||
| // } | ||
| // const newAlert = doChecksForAlerts(mutationToPublish, mode === ModalMode.Editing) | ||
| // if (newAlert) { | ||
| // setAlert(newAlert) | ||
| // return | ||
| // } | ||
| // if (mode === ModalMode.Creating || mode === ModalMode.Forking) { | ||
| // try { | ||
| // const id = await createMutation( | ||
| // mutationToPublish, | ||
| // mode === ModalMode.Forking | ||
| // ? { askOriginToApplyChanges: isApplyToOriginChecked } | ||
| // : undefined | ||
| // ) | ||
| // switchMutation(id) | ||
| // switchPreferredSource(id, EntitySourceType.Origin) | ||
| // await deleteLocalMutation(mutationToPublish.id) | ||
| // onCloseAll() | ||
| // } catch (error: any) { | ||
| // if (error?.message === 'Mutation with that ID already exists') { | ||
| // setAlert(alerts.idIsNotUnique) | ||
| // } | ||
| // } | ||
| // } else if (mode === ModalMode.Editing) { | ||
| // try { | ||
| // await editMutation( | ||
| // mutationToPublish as MutationDto, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Bug fix
[x] New feature
[ ] Documentation update
[ ] Add something to the core
[ ] Other, please explain:
Add a reference to a related issue if it exists
issue:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?