fix: update modals delete to overlay #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 90 days! |
alsakhaev
requested changes
Apr 30, 2025
Comment on lines
+286
to
+291
| onAction={async () => { | ||
| await deleteLocalMutation(mutationIdToDelete) | ||
| if (mutationIdToDelete === favoriteMutationId) | ||
| handleFavoriteButtonClick(mutationIdToDelete) | ||
| setMutationIdToDelete(null) | ||
| }} |
Member
There was a problem hiding this comment.
extract handlers to separate functions
Member
|
@Lisofffa add Jira task ID to the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Add something to the core
[ ] Other, please explain:
Add a reference to a related issue if it exists
issue:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?