#3182. Update augmenting_functions_A02_*.dart test
#3426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 2, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, with a couple of typos.
| /// before it in the augmentation chain is also complete. | ||
| /// | ||
| /// @description Checks that it is a compile-time error to add a body to already | ||
| /// completed top level function. |
Member
There was a problem hiding this comment.
I think 'complete' is better than 'completed' (we haven't defined what it means to be a 'completed function', but 'complete declaration' including 'complete function' is well-defined).
Suggested change
| /// completed top level function. | |
| /// complete top level function. |
A few other places use the same terminology.
| /// It's a compile-time error if an augmentation is complete and any declaration | ||
| /// before it in the augmentation chain is also complete. | ||
| /// | ||
| /// @description Checks that it is a compile-time error to add a body to already |
Member
There was a problem hiding this comment.
Typo:
Suggested change
| /// @description Checks that it is a compile-time error to add a body to already | |
| /// @description Checks that it is a compile-time error to add a body to an already |
A few other locations have the same issue.
Contributor
Author
|
Thank you! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.