Add 10 more lint rules (#2352)

Author: srawlins

analysis_options.yaml

@@ -17,15 +17,25 @@ analyzer:
 linter:
   rules:
     - always_declare_return_types
+    - avoid_single_cascade_in_expression_statements
+    - avoid_unused_constructor_parameters
     - annotate_overrides
     - avoid_init_to_null
     - avoid_types_as_parameter_names
+    - camel_case_types
     - directives_ordering
+    - iterable_contains_unrelated_type
+    - list_remove_unrelated_type
     - no_adjacent_strings_in_list
     - package_api_docs
     - prefer_final_fields
     - prefer_generic_function_type_aliases
+    - prefer_initializing_formals
+    - prefer_void_to_null
+    - provide_deprecation_message
     - slash_for_doc_comments
     - type_annotate_public_apis
     - unawaited_futures
-#    - unnecessary_brace_in_string_interps
+    #    - unnecessary_brace_in_string_interps
+    - unnecessary_overrides
+    - void_checks

lib/src/dartdoc_options.dart

@@ -454,8 +454,7 @@ class _OptionValueWithContext<T> {
   ///
   /// [path] is the path where this value came from (not required to be
   /// canonical).
-  _OptionValueWithContext(this.value, String path, {String definingFile}) {
-    this.definingFile = definingFile;
+  _OptionValueWithContext(this.value, String path, {this.definingFile}) {
     canonicalDirectoryPath = p.canonicalize(path);
     pathContext = p.Context(current: canonicalDirectoryPath);
   }
@@ -690,8 +689,7 @@ abstract class DartdocOption<T> {
   void _onAdd() {}
 
   /// Adds a list of dartdoc options to the children of this DartdocOption.
-  void addAll(Iterable<DartdocOption<Object>> options) =>
-      options.forEach((o) => add(o));
+  void addAll(Iterable<DartdocOption<Object>> options) => options.forEach(add);
 
   /// Get the immediate child of this node named [name].
   DartdocOption<dynamic> operator [](String name) {
@@ -856,7 +854,7 @@ typedef OptionGenerator = Future<List<DartdocOption<Object>>> Function(
 
 /// A [DartdocOption] that only contains other [DartdocOption]s and is not an
 /// option itself.
-class DartdocOptionSet extends DartdocOption<Null> {
+class DartdocOptionSet extends DartdocOption<void> {
   DartdocOptionSet(String name, ResourceProvider resourceProvider)
       : super(name, null, null, false, false, false, null, resourceProvider);
 
@@ -880,7 +878,7 @@ class DartdocOptionSet extends DartdocOption<Null> {
 
   /// [DartdocOptionSet] always has the null value.
   @override
-  Null valueAt(Folder dir) => null;
+  void valueAt(Folder dir) => null;
 
   /// Since we have no value, [_onMissing] does nothing.
   @override

lib/src/model/accessor.dart

@@ -39,11 +39,6 @@ class Accessor extends ModelElement implements EnclosedElement {
     return _sourceCode;
   }
 
-  @override
-  List<ModelElement> get computeDocumentationFrom {
-    return super.computeDocumentationFrom;
-  }
-
   @override
   String computeDocumentationComment() {
     if (isSynthetic) {

test/dartdoc_options_test.dart

@@ -178,9 +178,10 @@ void main() {
     secondDir = resourceProvider
         .getFolder(resourceProvider.pathContext.join(tempDir.path, 'secondDir'))
           ..create();
-    resourceProvider.getFile(
-        resourceProvider.pathContext.join(secondDir.path, 'existing.dart'))
-      ..writeAsStringSync('');
+    resourceProvider
+        .getFile(
+            resourceProvider.pathContext.join(secondDir.path, 'existing.dart'))
+        .writeAsStringSync('');
 
     secondDirFirstSub = resourceProvider.getFolder(
         resourceProvider.pathContext.join(secondDir.path, 'firstSub'))

tool/grind.dart

@@ -205,7 +205,7 @@ void updateThirdParty() async {
   for (var patchFileName in Directory(_pkgDir.path)
       .listSync()
       .map((e) => path.basename(e.path))
-      .where((String filename) => _mustache4dartPatches.hasMatch(filename))
+      .where(_mustache4dartPatches.hasMatch)
       .toList()
         ..sort()) {
     run('patch',