Enable preview-dart-2 by default (#1630)

* Enable preview-dart-2 by default

* new sdk

* Turn on preview-dart-2 in the analyzer for Dartdoc.

* Avoid newly deprecated ParameterKind usage

Author: jcollins-g

analysis_options.yaml

@@ -2,6 +2,7 @@ analyzer:
   strong-mode: true
   language:
     enableGenericMethods: true
+    enablePreviewDart2: true
     enableSuperMixins: true
   exclude:
     - 'doc/**'

lib/src/model.dart

@@ -31,7 +31,6 @@ import 'package:analyzer/src/generated/resolver.dart'
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
-import 'package:analyzer/src/generated/utilities_dart.dart' show ParameterKind;
 import 'package:analyzer/src/dart/element/member.dart'
     show ExecutableMember, Member, ParameterMember;
 import 'package:analyzer/src/dart/analysis/driver.dart';
@@ -4590,12 +4589,11 @@ class Parameter extends ModelElement implements EnclosedElement {
     return '${enclosingName}-param-${name}';
   }
 
-  bool get isOptional => _parameter.parameterKind.isOptional;
+  bool get isOptional => _parameter.isOptional;
 
-  bool get isOptionalNamed => _parameter.parameterKind == ParameterKind.NAMED;
+  bool get isOptionalNamed => _parameter.isNamed;
 
-  bool get isOptionalPositional =>
-      _parameter.parameterKind == ParameterKind.POSITIONAL;
+  bool get isOptionalPositional => _parameter.isOptionalPositional;
 
   @override
   String get kind => 'parameter';
@@ -5054,6 +5052,7 @@ class PackageBuilder {
       AnalysisOptionsImpl options = new AnalysisOptionsImpl();
       options.strongMode = true;
       options.enableSuperMixins = true;
+      options.previewDart2 = true;
 
       // TODO(jcollins-g): Make use of currently not existing API for managing
       //                   many AnalysisDrivers

pubspec.lock

@@ -7,7 +7,7 @@ packages:
       name: analyzer
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.31.2-alpha.0"
+    version: "0.31.2-alpha.1"
   args:
     dependency: "direct main"
     description:
@@ -91,7 +91,7 @@ packages:
       name: front_end
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.1.0-alpha.10"
+    version: "0.1.0-alpha.11"
   glob:
     dependency: transitive
     description:
@@ -161,7 +161,7 @@ packages:
       name: kernel
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.3.0-alpha.10"
+    version: "0.3.0-alpha.11"
   logging:
     dependency: "direct main"
     description:
@@ -408,4 +408,4 @@ packages:
     source: hosted
     version: "2.1.13"
 sdks:
-  dart: ">=2.0.0-dev.23.0 <=2.0.0-dev.39.0"
+  dart: ">=2.0.0-dev.23.0 <=2.0.0-dev.40.0"

pubspec.yaml

@@ -9,10 +9,10 @@ homepage: https://github.com/dart-lang/dartdoc
 environment:
   sdk: '>=2.0.0-dev.9.0 <3.0.0'
 dependencies:
-  analyzer: '0.31.2-alpha.0'
+  analyzer: '0.31.2-alpha.1'
   args: '>=0.13.0 <2.0.0'
   collection: ^1.2.0
-  front_end: ^0.1.0-alpha.10
+  front_end: ^0.1.0-alpha.11
   html: '>=0.12.1 <0.14.0'
   # We don't use http_parser directly; this dep exists to ensure that we get at
   # least version 3.0.3 to work around an issue with 3.0.2.

testing/test_package/lib/fake.dart

@@ -223,6 +223,12 @@ class Cool {
   Cool returnCool() {}
 }
 
+/// A map initialization making use of optional const.
+const Map<int, String> myMap = { 1: "hello" };
+
+/// A variable initalization making use of optional new.
+Cool aCoolVariable = Cool();
+
 /// Perfect for mix-ins.
 abstract class MixMeIn {}
 

testing/test_package_docs/fake/ABaseClass-class.html

@@ -90,6 +90,7 @@ <h5>fake library</h5>
       <li><a href="fake/greatAnnotation-constant.html">greatAnnotation</a></li>
       <li><a href="fake/greatestAnnotation-constant.html">greatestAnnotation</a></li>
       <li><a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a></li>
+      <li><a href="fake/myMap-constant.html">myMap</a></li>
       <li><a href="fake/NAME_SINGLEUNDERSCORE-constant.html">NAME_SINGLEUNDERSCORE</a></li>
       <li><a href="fake/NAME_WITH_TWO_UNDERSCORES-constant.html">NAME_WITH_TWO_UNDERSCORES</a></li>
       <li><a href="fake/PI-constant.html">PI</a></li>
@@ -99,6 +100,7 @@ <h5>fake library</h5>
       <li><a href="fake/ZERO-constant.html">ZERO</a></li>
 
       <li class="section-title"><a href="fake/fake-library.html#properties">Properties</a></li>
+      <li><a href="fake/aCoolVariable.html">aCoolVariable</a></li>
       <li><a href="fake/dynamicGetter.html">dynamicGetter</a></li>
       <li><a href="fake/getterSetterNodocGetter.html">getterSetterNodocGetter</a></li>
       <li><a href="fake/getterSetterNodocSetter.html">getterSetterNodocSetter</a></li>

testing/test_package_docs/fake/AClassUsingASuperMixin-class.html

@@ -90,6 +90,7 @@ <h5>fake library</h5>
       <li><a href="fake/greatAnnotation-constant.html">greatAnnotation</a></li>
       <li><a href="fake/greatestAnnotation-constant.html">greatestAnnotation</a></li>
       <li><a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a></li>
+      <li><a href="fake/myMap-constant.html">myMap</a></li>
       <li><a href="fake/NAME_SINGLEUNDERSCORE-constant.html">NAME_SINGLEUNDERSCORE</a></li>
       <li><a href="fake/NAME_WITH_TWO_UNDERSCORES-constant.html">NAME_WITH_TWO_UNDERSCORES</a></li>
       <li><a href="fake/PI-constant.html">PI</a></li>
@@ -99,6 +100,7 @@ <h5>fake library</h5>
       <li><a href="fake/ZERO-constant.html">ZERO</a></li>
 
       <li class="section-title"><a href="fake/fake-library.html#properties">Properties</a></li>
+      <li><a href="fake/aCoolVariable.html">aCoolVariable</a></li>
       <li><a href="fake/dynamicGetter.html">dynamicGetter</a></li>
       <li><a href="fake/getterSetterNodocGetter.html">getterSetterNodocGetter</a></li>
       <li><a href="fake/getterSetterNodocSetter.html">getterSetterNodocSetter</a></li>

testing/test_package_docs/fake/AClassWithFancyProperties-class.html

@@ -90,6 +90,7 @@ <h5>fake library</h5>
       <li><a href="fake/greatAnnotation-constant.html">greatAnnotation</a></li>
       <li><a href="fake/greatestAnnotation-constant.html">greatestAnnotation</a></li>
       <li><a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a></li>
+      <li><a href="fake/myMap-constant.html">myMap</a></li>
       <li><a href="fake/NAME_SINGLEUNDERSCORE-constant.html">NAME_SINGLEUNDERSCORE</a></li>
       <li><a href="fake/NAME_WITH_TWO_UNDERSCORES-constant.html">NAME_WITH_TWO_UNDERSCORES</a></li>
       <li><a href="fake/PI-constant.html">PI</a></li>
@@ -99,6 +100,7 @@ <h5>fake library</h5>
       <li><a href="fake/ZERO-constant.html">ZERO</a></li>
 
       <li class="section-title"><a href="fake/fake-library.html#properties">Properties</a></li>
+      <li><a href="fake/aCoolVariable.html">aCoolVariable</a></li>
       <li><a href="fake/dynamicGetter.html">dynamicGetter</a></li>
       <li><a href="fake/getterSetterNodocGetter.html">getterSetterNodocGetter</a></li>
       <li><a href="fake/getterSetterNodocSetter.html">getterSetterNodocSetter</a></li>

testing/test_package_docs/fake/AMixinCallingSuper-class.html

@@ -90,6 +90,7 @@ <h5>fake library</h5>
       <li><a href="fake/greatAnnotation-constant.html">greatAnnotation</a></li>
       <li><a href="fake/greatestAnnotation-constant.html">greatestAnnotation</a></li>
       <li><a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a></li>
+      <li><a href="fake/myMap-constant.html">myMap</a></li>
       <li><a href="fake/NAME_SINGLEUNDERSCORE-constant.html">NAME_SINGLEUNDERSCORE</a></li>
       <li><a href="fake/NAME_WITH_TWO_UNDERSCORES-constant.html">NAME_WITH_TWO_UNDERSCORES</a></li>
       <li><a href="fake/PI-constant.html">PI</a></li>
@@ -99,6 +100,7 @@ <h5>fake library</h5>
       <li><a href="fake/ZERO-constant.html">ZERO</a></li>
 
       <li class="section-title"><a href="fake/fake-library.html#properties">Properties</a></li>
+      <li><a href="fake/aCoolVariable.html">aCoolVariable</a></li>
       <li><a href="fake/dynamicGetter.html">dynamicGetter</a></li>
       <li><a href="fake/getterSetterNodocGetter.html">getterSetterNodocGetter</a></li>
       <li><a href="fake/getterSetterNodocSetter.html">getterSetterNodocSetter</a></li>

testing/test_package_docs/fake/ATypeTakingClass-class.html

@@ -90,6 +90,7 @@ <h5>fake library</h5>
       <li><a href="fake/greatAnnotation-constant.html">greatAnnotation</a></li>
       <li><a href="fake/greatestAnnotation-constant.html">greatestAnnotation</a></li>
       <li><a href="fake/incorrectDocReference-constant.html">incorrectDocReference</a></li>
+      <li><a href="fake/myMap-constant.html">myMap</a></li>
       <li><a href="fake/NAME_SINGLEUNDERSCORE-constant.html">NAME_SINGLEUNDERSCORE</a></li>
       <li><a href="fake/NAME_WITH_TWO_UNDERSCORES-constant.html">NAME_WITH_TWO_UNDERSCORES</a></li>
       <li><a href="fake/PI-constant.html">PI</a></li>
@@ -99,6 +100,7 @@ <h5>fake library</h5>
       <li><a href="fake/ZERO-constant.html">ZERO</a></li>
 
       <li class="section-title"><a href="fake/fake-library.html#properties">Properties</a></li>
+      <li><a href="fake/aCoolVariable.html">aCoolVariable</a></li>
       <li><a href="fake/dynamicGetter.html">dynamicGetter</a></li>
       <li><a href="fake/getterSetterNodocGetter.html">getterSetterNodocGetter</a></li>
       <li><a href="fake/getterSetterNodocSetter.html">getterSetterNodocSetter</a></li>