[native_assets_cli] Validate that paths are absolute in Input and Output (#1935)

Closes: #1605

Reuses the same validation (and error messages) for checking that files/directories exist and that their paths are absolute.

Also, adds a script to automatically update the `manifest.yaml` files. (It seems that `sort lines ascending` in vscode orders `/` and `_` differently than the string compiler in Dart. Hence the reordering.)

Author: dcharkes

pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart

@@ -162,7 +162,7 @@ class NativeAssetsBuildRunner {
       ];
       if (errors.isNotEmpty) {
         return _printErrors(
-            'Build configuration for ${package.name} contains errors', errors);
+            'Build input for ${package.name} contains errors', errors);
       }
 
       final result = await _runHookForPackageCached(
@@ -247,8 +247,9 @@ class NativeAssetsBuildRunner {
         ...await inputValidator(input),
       ];
       if (errors.isNotEmpty) {
+        print(input.assets.encodedAssets);
         return _printErrors(
-            'Link configuration for ${package.name} contains errors', errors);
+            'Link input for ${package.name} contains errors', errors);
       }
 
       final result = await _runHookForPackageCached(

pkgs/native_assets_builder/test/build_runner/absolute_path_test.dart

@@ -0,0 +1,36 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:test/test.dart';
+
+import '../helpers.dart';
+import 'helpers.dart';
+
+void main() async {
+  test('relative path', () async {
+    await inTempDir((tempUri) async {
+      await copyTestProjects(targetUri: tempUri);
+      final packageUri = tempUri.resolve('relative_path/');
+
+      await runPubGet(
+        workingDirectory: packageUri,
+        logger: logger,
+      );
+
+      {
+        final logMessages = <String>[];
+        final result = await buildDataAssets(
+          packageUri,
+          capturedLogs: logMessages,
+        );
+        final fullLog = logMessages.join('\n');
+        expect(result, isNull);
+        expect(
+          fullLog,
+          contains('must be an absolute path'),
+        );
+      }
+    });
+  });
+}

pkgs/native_assets_builder/test/build_runner/helpers.dart

@@ -29,6 +29,25 @@ Future<void> runPubGet({
   expect(result.exitCode, 0);
 }
 
+Future<BuildResult?> buildDataAssets(
+  Uri packageUri, {
+  String? runPackageName,
+  List<String>? capturedLogs,
+  bool linkingEnabled = false,
+}) =>
+    build(
+      packageUri,
+      logger,
+      dartExecutable,
+      capturedLogs: capturedLogs,
+      buildAssetTypes: [DataAsset.type],
+      inputValidator: validateDataAssetBuildInput,
+      buildValidator: validateDataAssetBuildOutput,
+      applicationAssetValidator: (_) async => [],
+      runPackageName: runPackageName,
+      linkingEnabled: linkingEnabled,
+    );
+
 Future<BuildResult?> buildCodeAssets(
   Uri packageUri, {
   String? runPackageName,

pkgs/native_assets_builder/test/build_runner/link_caching_test.dart

@@ -29,16 +29,10 @@ void main() async {
       late LinkResult linkResult;
       Future<void> runBuild() async {
         logMessages.clear();
-        buildResult = (await build(
+        buildResult = (await buildDataAssets(
           packageUri,
-          logger,
-          dartExecutable,
           linkingEnabled: true,
-          buildAssetTypes: [DataAsset.type],
           capturedLogs: logMessages,
-          inputValidator: validateDataAssetBuildInput,
-          buildValidator: validateDataAssetBuildOutput,
-          applicationAssetValidator: (_) async => [],
         ))!;
       }
 

pkgs/native_assets_builder/test/build_runner/link_test.dart

@@ -26,15 +26,9 @@ void main() async {
           logger: logger,
         );
 
-        final buildResult = (await build(
+        final buildResult = (await buildDataAssets(
           packageUri,
-          logger,
-          dartExecutable,
           linkingEnabled: true,
-          buildAssetTypes: [DataAsset.type],
-          inputValidator: validateDataAssetBuildInput,
-          buildValidator: validateDataAssetBuildOutput,
-          applicationAssetValidator: (_) async => [],
         ))!;
         expect(buildResult.encodedAssets.length, 0);
 
@@ -50,15 +44,9 @@ void main() async {
         ))!;
         expect(linkResult.encodedAssets.length, 2);
 
-        final buildNoLinkResult = (await build(
+        final buildNoLinkResult = (await buildDataAssets(
           packageUri,
-          logger,
-          dartExecutable,
           linkingEnabled: false,
-          buildAssetTypes: [DataAsset.type],
-          inputValidator: validateDataAssetBuildInput,
-          buildValidator: validateDataAssetBuildOutput,
-          applicationAssetValidator: (_) async => [],
         ))!;
         expect(buildNoLinkResult.encodedAssets.length, 4);
       });
@@ -96,15 +84,9 @@ void main() async {
         // First, run `pub get`, we need pub to resolve our dependencies.
         await runPubGet(workingDirectory: packageUri, logger: logger);
 
-        final buildResult = await build(
+        final buildResult = await buildDataAssets(
           packageUri,
-          logger,
-          dartExecutable,
           linkingEnabled: true,
-          buildAssetTypes: [DataAsset.type],
-          inputValidator: validateDataAssetBuildInput,
-          buildValidator: validateDataAssetBuildOutput,
-          applicationAssetValidator: (_) async => [],
         );
         expect(buildResult, isNotNull);
         expect(_getNames(buildResult!.encodedAssets),
@@ -143,15 +125,9 @@ void main() async {
         logger: logger,
       );
 
-      final buildResult = (await build(
+      final buildResult = (await buildDataAssets(
         packageUri,
-        logger,
-        dartExecutable,
         linkingEnabled: true,
-        buildAssetTypes: [DataAsset.type],
-        inputValidator: validateDataAssetBuildInput,
-        buildValidator: validateDataAssetBuildOutput,
-        applicationAssetValidator: (_) async => [],
       ))!;
       expect(buildResult.encodedAssets.length, 0);
       expect(buildResult.encodedAssetsForLinking.length, 0);

pkgs/native_assets_builder/test/build_runner/resources_test.dart

@@ -29,15 +29,9 @@ void main() async {
           logger: logger,
         );
 
-        final buildResult = (await build(
+        final buildResult = (await buildDataAssets(
           packageUri,
-          logger,
-          dartExecutable,
           linkingEnabled: true,
-          buildAssetTypes: [DataAsset.type],
-          inputValidator: validateDataAssetBuildInput,
-          buildValidator: validateDataAssetBuildOutput,
-          applicationAssetValidator: (_) async => [],
         ))!;
 
         Iterable<String> buildFiles() => Directory.fromUri(

pkgs/native_assets_builder/test_data/manifest.yaml

@@ -1,44 +1,45 @@
 # The list of files to copy to a temporary folder to ensure running tests from
 # a completely clean setup.
+# Automatically generated by manifest_generator.dart.
 - add_asset_link/bin/add_asset_link.dart
 - add_asset_link/hook/build.dart
 - add_asset_link/hook/link.dart
 - add_asset_link/lib/add_asset_link.dart
-- add_asset_link/lib/src/add_asset_link_bindings.dart
 - add_asset_link/lib/src/add_asset_link.dart
+- add_asset_link/lib/src/add_asset_link_bindings.dart
 - add_asset_link/pubspec.yaml
 - add_asset_link/src/native_add.c
 - add_asset_link/src/native_add.h
+- complex_link/assets/data_0.json
+- complex_link/assets/data_1.json
+- complex_link/bin/complex_link.dart
+- complex_link/hook/build.dart
+- complex_link/hook/link.dart
+- complex_link/pubspec.yaml
 - complex_link_helper/assets/data_helper_0.json
 - complex_link_helper/assets/data_helper_1.json
 - complex_link_helper/assets/data_helper_2.json
 - complex_link_helper/assets/data_helper_3.json
 - complex_link_helper/hook/build.dart
 - complex_link_helper/lib/complex_link_helper.dart
 - complex_link_helper/pubspec.yaml
-- complex_link/assets/data_0.json
-- complex_link/assets/data_1.json
-- complex_link/bin/complex_link.dart
-- complex_link/hook/build.dart
-- complex_link/hook/link.dart
-- complex_link/pubspec.yaml
 - cyclic_package_1/hook/build.dart
 - cyclic_package_1/pubspec.yaml
 - cyclic_package_2/hook/build.dart
 - cyclic_package_2/pubspec.yaml
 - dart_app/bin/dart_app.dart
 - dart_app/pubspec.yaml
-- depend_on_fail_build_app/bin/depend_on_fail_build_app.dart
-- depend_on_fail_build_app/pubspec.yaml
 - depend_on_fail_build/hook/build.dart
 - depend_on_fail_build/lib/depend_on_fail_build.dart
 - depend_on_fail_build/pubspec.yaml
+- depend_on_fail_build_app/bin/depend_on_fail_build_app.dart
+- depend_on_fail_build_app/pubspec.yaml
 - drop_dylib_link/bin/drop_dylib_link.dart
 - drop_dylib_link/hook/build.dart
 - drop_dylib_link/hook/link.dart
 - drop_dylib_link/lib/drop_dylib_link.dart
-- drop_dylib_link/lib/src/drop_dylib_link_bindings.dart
 - drop_dylib_link/lib/src/drop_dylib_link.dart
+- drop_dylib_link/lib/src/drop_dylib_link_bindings.dart
 - drop_dylib_link/pubspec.yaml
 - drop_dylib_link/src/native_add.c
 - drop_dylib_link/src/native_add.h
@@ -47,13 +48,22 @@
 - fail_build/hook/build.dart
 - fail_build/lib/fail_build.dart
 - fail_build/pubspec.yaml
+- fail_on_os_sdk_version/hook/build.dart
+- fail_on_os_sdk_version/pubspec.yaml
 - fail_on_os_sdk_version_link/assets/data.json
 - fail_on_os_sdk_version_link/hook/build.dart
 - fail_on_os_sdk_version_link/pubspec.yaml
 - fail_on_os_sdk_version_linker/hook/link.dart
 - fail_on_os_sdk_version_linker/pubspec.yaml
-- fail_on_os_sdk_version/hook/build.dart
-- fail_on_os_sdk_version/pubspec.yaml
+- native_add/ffigen.yaml
+- native_add/hook/build.dart
+- native_add/lib/native_add.dart
+- native_add/lib/src/native_add.dart
+- native_add/lib/src/native_add_bindings_generated.dart
+- native_add/pubspec.yaml
+- native_add/src/native_add.c
+- native_add/src/native_add.h
+- native_add/test/native_add_test.dart
 - native_add_duplicate/bin/native_add_duplicate.dart
 - native_add_duplicate/hook/build.dart
 - native_add_duplicate/hook/link.dart
@@ -63,29 +73,19 @@
 - native_add_version_skew/ffigen.yaml
 - native_add_version_skew/hook/build.dart
 - native_add_version_skew/lib/native_add.dart
-- native_add_version_skew/lib/src/native_add_bindings_generated.dart
 - native_add_version_skew/lib/src/native_add.dart
+- native_add_version_skew/lib/src/native_add_bindings_generated.dart
 - native_add_version_skew/pubspec.yaml
 - native_add_version_skew/src/native_add.c
 - native_add_version_skew/src/native_add.h
 - native_add_version_skew/test/native_add_test.dart
 - native_add_version_skew_2/hook/build.dart
 - native_add_version_skew_2/pubspec.yaml
-- native_add/ffigen.yaml
-- native_add/hook/build.dart
-- native_add/lib/native_add.dart
-- native_add/lib/src/native_add_bindings_generated.dart
-- native_add/lib/src/native_add.dart
-- native_add/pubspec.yaml
-- native_add/src/native_add.c
-- native_add/src/native_add.h
-- native_add/test/native_add_test.dart
 - native_dynamic_linking/bin/native_dynamic_linking.dart
 - native_dynamic_linking/ffigen.yaml
 - native_dynamic_linking/hook/build.dart
 - native_dynamic_linking/lib/add.dart
 - native_dynamic_linking/pubspec.yaml
-- native_dynamic_linking/README.md
 - native_dynamic_linking/src/add.c
 - native_dynamic_linking/src/add.h
 - native_dynamic_linking/src/debug.c
@@ -96,8 +96,8 @@
 - native_subtract/ffigen.yaml
 - native_subtract/hook/build.dart
 - native_subtract/lib/native_subtract.dart
-- native_subtract/lib/src/native_subtract_bindings_generated.dart
 - native_subtract/lib/src/native_subtract.dart
+- native_subtract/lib/src/native_subtract_bindings_generated.dart
 - native_subtract/pubspec.yaml
 - native_subtract/src/native_subtract.c
 - native_subtract/src/native_subtract.h
@@ -109,17 +109,20 @@
 - package_reading_metadata/pubspec.yaml
 - package_with_metadata/hook/build.dart
 - package_with_metadata/pubspec.yaml
+- relative_path/assets/test_asset.txt
+- relative_path/hook/build.dart
+- relative_path/pubspec.yaml
 - simple_data_asset/assets/test_asset.txt
 - simple_data_asset/bin/deep_modify_data_asset.dart.debug
 - simple_data_asset/bin/modify_data_asset.dart.debug
 - simple_data_asset/bin/simple_data_asset.dart.debug
 - simple_data_asset/hook/build.dart
 - simple_data_asset/pubspec.yaml
-- simple_data_asset/README.md
 - simple_link/assets/data_0.json
 - simple_link/assets/data_1.json
 - simple_link/assets/data_2.json
 - simple_link/assets/data_3.json
+- simple_link/bin/simple_link.dart
 - simple_link/hook/build.dart
 - simple_link/hook/link.dart
 - simple_link/pubspec.yaml
@@ -149,20 +152,24 @@
 - treeshaking_native_libs/ffigen.yaml
 - treeshaking_native_libs/hook/build.dart
 - treeshaking_native_libs/hook/link.dart
-- treeshaking_native_libs/lib/src/treeshaking_native_libs_bindings_generated.dart
 - treeshaking_native_libs/lib/src/treeshaking_native_libs.dart
+- treeshaking_native_libs/lib/src/treeshaking_native_libs_bindings_generated.dart
 - treeshaking_native_libs/lib/treeshaking_native_libs.dart
 - treeshaking_native_libs/pubspec.yaml
 - treeshaking_native_libs/src/native_add.c
 - treeshaking_native_libs/src/native_add.h
 - treeshaking_native_libs/src/native_multiply.c
 - treeshaking_native_libs/src/native_multiply.h
+- treeshaking_native_libs/test/treeshaking_native_libs_test.dart
+- use_all_api/hook/build.dart
+- use_all_api/hook/link.dart
+- use_all_api/pubspec.yaml
+- wrong_build_output/hook/build.dart
+- wrong_build_output/pubspec.yaml
 - wrong_build_output_2/hook/build.dart
 - wrong_build_output_2/pubspec.yaml
 - wrong_build_output_3/hook/build.dart
 - wrong_build_output_3/pubspec.yaml
-- wrong_build_output/hook/build.dart
-- wrong_build_output/pubspec.yaml
 - wrong_linker/hook/build.dart
 - wrong_linker/pubspec.yaml
 - wrong_namespace_asset/hook/build.dart