Skip to content

Conversation

@goderbauer
Copy link
Contributor

@goderbauer goderbauer commented Nov 28, 2025

Bumping dependencies of native_doc_dartifier was excluded from this because of #2839.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
code_assets None 1.0.0 1.0.0 1.0.0 ✔️
data_assets None 0.19.6 0.19.6 0.19.6 ✔️
hooks None 1.0.0 1.0.0 1.0.0 ✔️
hooks_runner None 1.0.1 1.0.2-wip 1.0.1 ✔️
native_toolchain_c None 0.17.4 0.17.4 0.17.4 ✔️
objective_c Non-Breaking 9.2.1 9.2.1 9.2.2
Got "9.2.1" expected >= "9.2.2" (non-breaking changes --> patch)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

@coveralls
Copy link

coveralls commented Nov 28, 2025

Coverage Status

coverage: 81.94% (-0.7%) from 82.602%
when pulling 26b915e on goderbauer:depbump
into 77c2e52 on dart-lang:main.

@goderbauer
Copy link
Contributor Author

The coverage upload is consistently failing across the board. Unfortunately, it seems like that no error is given. @liamappelbe do you happen to have any idea why this could be failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants