Bump min Dart SDK to 3.9, reformat (#2251)

Author: kevmoo

.github/workflows/markdown.yaml

@@ -70,7 +70,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [3.4, dev]
+        sdk: [3.9, dev]
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
       - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c

pkgs/markdown/CHANGELOG.md

@@ -10,7 +10,7 @@
 * Fix an issue with nested list structure when indented by tabs (#2172).
 * Deprecated `LinkContext` and `BlockParser.standardBlockSyntaxes`.
   Implementation members that should never have been made public.
-* Require Dart `^3.4.0`.
+* Require Dart `^3.9.0`.
 
 ## 7.3.0
 

pkgs/markdown/analysis_options.yaml

@@ -23,8 +23,9 @@ linter:
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - prefer_const_declarations
-    - prefer_final_locals
     - prefer_final_in_for_each
+    - prefer_final_locals
+    - remove_deprecations_in_breaking_versions
     - unnecessary_await_in_return
     - unnecessary_raw_strings
     - use_if_null_to_convert_nulls_to_bools

pkgs/markdown/example/app.dart

@@ -131,9 +131,7 @@ void _switchFlavor(Event e) {
 }
 
 extension on NodeList {
-  List<Node> get items => [
-        for (var i = 0; i < length; i++) item(i)!,
-      ];
+  List<Node> get items => [for (var i = 0; i < length; i++) item(i)!];
 }
 
 extension on NamedNodeMap {

pkgs/markdown/lib/src/assets/case_folding.dart

@@ -1312,5 +1312,5 @@ const caseFoldingMap = {
   "𞤞": "𞥀",
   "𞤟": "𞥁",
   "𞤠": "𞥂",
-  "𞤡": "𞥃"
+  "𞤡": "𞥃",
 };

pkgs/markdown/lib/src/assets/html_entities.dart

@@ -2129,5 +2129,5 @@ const htmlEntitiesMap = {
   "𝕫": "𝕫",
   "𝓏": "𝓏",
   "‍": "‍",
-  "‌": "‌"
+  "‌": "‌",
 };

pkgs/markdown/lib/src/ast.dart

@@ -25,19 +25,15 @@ class Element implements Node {
   Element(this.tag, this.children) : attributes = {};
 
   /// Instantiates an empty, self-closing [tag] Element.
-  Element.empty(this.tag)
-      : children = null,
-        attributes = {};
+  Element.empty(this.tag) : children = null, attributes = {};
 
   /// Instantiates a [tag] Element with no [children].
-  Element.withTag(this.tag)
-      : children = const [],
-        attributes = {};
+  Element.withTag(this.tag) : children = const [], attributes = {};
 
   /// Instantiates a [tag] Element with a single Text child.
   Element.text(this.tag, String text)
-      : children = [Text(text)],
-        attributes = {};
+    : children = [Text(text)],
+      attributes = {};
 
   /// Whether this element is self-closing.
   bool get isEmpty => children == null;

pkgs/markdown/lib/src/block_parser.dart

@@ -58,8 +58,10 @@ class BlockParser {
   /// The collection of built-in block parsers.
   // TODO(kevmoo): this should be static const and private!
   // The fact that it's mutable is a BUG!
-  @Deprecated('Implementation member. '
-      'Will be removed or make static in the next release.')
+  @Deprecated(
+    'Implementation member. '
+    'Will be removed or make static in the next release.',
+  )
   final List<BlockSyntax> standardBlockSyntaxes = [
     const EmptyBlockSyntax(),
     const HtmlBlockSyntax(),
@@ -71,7 +73,7 @@ class BlockParser {
     const UnorderedListSyntax(),
     const OrderedListSyntax(),
     const LinkReferenceDefinitionSyntax(),
-    const ParagraphSyntax()
+    const ParagraphSyntax(),
   ];
 
   BlockParser(this.lines, this.document) {

pkgs/markdown/lib/src/block_syntaxes/alert_block_syntax.dart

@@ -57,8 +57,9 @@ class AlertBlockSyntax extends BlockSyntax {
       // a Setext header.
       // Because indented code blocks cannot interrupt paragraphs, a line
       // matched CodeBlockSyntax is also paragraph continuation text.
-      final otherMatched =
-          parser.blockSyntaxes.firstWhere((s) => s.canParse(parser));
+      final otherMatched = parser.blockSyntaxes.firstWhere(
+        (s) => s.canParse(parser),
+      );
       if ((otherMatched is ParagraphSyntax &&
               !lastLine.isBlankLine &&
               !codeFencePattern.hasMatch(lastLine.content)) ||
@@ -78,8 +79,10 @@ class AlertBlockSyntax extends BlockSyntax {
   @override
   Node parse(BlockParser parser) {
     // Parse the alert type from the first line.
-    final type =
-        pattern.firstMatch(parser.current.content)!.group(1)!.toLowerCase();
+    final type = pattern
+        .firstMatch(parser.current.content)!
+        .group(1)!
+        .toLowerCase();
     parser.advance();
     final childLines = parseChildLines(parser);
     // Recursively parse the contents of the alert.

pkgs/markdown/lib/src/block_syntaxes/block_syntax.dart

@@ -50,15 +50,18 @@ abstract class BlockSyntax {
   /// Gets whether or not [parser]'s current line should end the previous block.
   static bool isAtBlockEnd(BlockParser parser) {
     if (parser.isDone) return true;
-    return parser.blockSyntaxes
-        .any((s) => s.canParse(parser) && s.canEndBlock(parser));
+    return parser.blockSyntaxes.any(
+      (s) => s.canParse(parser) && s.canEndBlock(parser),
+    );
   }
 
   /// Generates a valid HTML anchor from the inner text of [element].
-  static String generateAnchorHash(Element element) =>
-      element.children!.first.textContent
-          .toLowerCase()
-          .trim()
-          .replaceAll(RegExp('[^a-z0-9 _-]'), '')
-          .replaceAll(RegExp(r'\s'), '-');
+  static String generateAnchorHash(Element element) => element
+      .children!
+      .first
+      .textContent
+      .toLowerCase()
+      .trim()
+      .replaceAll(RegExp('[^a-z0-9 _-]'), '')
+      .replaceAll(RegExp(r'\s'), '-');
 }