Skip to content

refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling) #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwvg wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling) #7112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
047c913
refactor: drop `emitCoinJoinEnabledChanged()`, use `setOption()` instead
kwvg Jan 28, 2026
2d9d9f4
refactor: improve CoinJoin tab nullptr checks, bail-out condition
kwvg Jan 21, 2026
7593046
move-only: move `subFeeFromAmount` into `verticalLayout_2`
kwvg Jan 18, 2026
6ce9aa5
chore: enforce alphabetical sorting in `src/Makefile.qt.include`
kwvg Jan 20, 2026
0fbc44f
refactor: add `getScaledFont` helper, keep `getFont` internal
kwvg Jan 22, 2026
135d19b
refactor: add `pruneStaleEntities` helper to deduplicate pruning
kwvg Jan 20, 2026
e6039cd
move-only: split proposal model out to `src/qt/proposalmodel.{cpp,h}`
kwvg Jan 28, 2026
0adbe3d
fix: use `unique_ptr` and more bounds checking in `qt/proposalmodel`
kwvg Jan 22, 2026
b6bcb6a
refactor: drop `QObject` inheritance, precalculate hash string
kwvg Jan 22, 2026
f667731
qt: add styling support for QTextEdit `<b>` and `<h{1-3}>` elements
kwvg Jan 28, 2026
6fb72ee
qt: use show/hide for "Governance" tab to avoid client restart
kwvg Jan 21, 2026
44662df
refactor: track "Governance" tab show/hide in `OptionsModel`
kwvg Jan 21, 2026
897fcbb
qt: use show/hide for "Masternodes" tab to avoid client restart
kwvg Jan 21, 2026
8af13b6
refactor: track "Masternodes" tab show/hide in `OptionsModel`
kwvg Jan 21, 2026
2240979
refactor: repurpose `transactiondescdialog` as a generic desc. container
kwvg Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 62 additions & 59 deletions src/Makefile.qt.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,33 +20,32 @@ QT_FORMS_UI = \
qt/forms/askpassphrasedialog.ui \
qt/forms/coincontroldialog.ui \
qt/forms/createwalletdialog.ui \
qt/forms/debugwindow.ui \
qt/forms/descriptiondialog.ui \
qt/forms/editaddressdialog.ui \
qt/forms/governancelist.ui \
qt/forms/proposalwizard.ui \
qt/forms/helpmessagedialog.ui \
qt/forms/intro.ui \
qt/forms/modaloverlay.ui \
qt/forms/masternodelist.ui \
qt/forms/mnemonicverificationdialog.ui \
qt/forms/qrdialog.ui \
qt/forms/modaloverlay.ui \
qt/forms/openuridialog.ui \
qt/forms/optionsdialog.ui \
qt/forms/overviewpage.ui \
qt/forms/proposalwizard.ui \
qt/forms/psbtoperationsdialog.ui \
qt/forms/qrdialog.ui \
qt/forms/receivecoinsdialog.ui \
qt/forms/receiverequestdialog.ui \
qt/forms/debugwindow.ui \
qt/forms/sendcoinsdialog.ui \
qt/forms/sendcoinsentry.ui \
qt/forms/signverifymessagedialog.ui \
qt/forms/transactiondescdialog.ui
qt/forms/signverifymessagedialog.ui

QT_MOC_CPP = \
qt/moc_addressbookpage.cpp \
qt/moc_addresstablemodel.cpp \
qt/moc_appearancewidget.cpp \
qt/moc_askpassphrasedialog.cpp \
qt/moc_createwalletdialog.cpp \
qt/moc_bantablemodel.cpp \
qt/moc_bitcoin.cpp \
qt/moc_bitcoinaddressvalidator.cpp \
Expand All @@ -56,26 +55,29 @@ QT_MOC_CPP = \
qt/moc_clientmodel.cpp \
qt/moc_coincontroldialog.cpp \
qt/moc_coincontroltreewidget.cpp \
qt/moc_createwalletdialog.cpp \
qt/moc_csvmodelwriter.cpp \
qt/moc_descriptiondialog.cpp \
qt/moc_editaddressdialog.cpp \
qt/moc_governancelist.cpp \
qt/moc_proposalwizard.cpp \
qt/moc_guiutil.cpp \
qt/moc_initexecutor.cpp \
qt/moc_intro.cpp \
qt/moc_macdockiconhandler.cpp \
qt/moc_macnotificationhandler.cpp \
qt/moc_modaloverlay.cpp \
qt/moc_masternodelist.cpp \
qt/moc_mnemonicverificationdialog.cpp \
qt/moc_modaloverlay.cpp \
qt/moc_notificator.cpp \
qt/moc_openuridialog.cpp \
qt/moc_optionsdialog.cpp \
qt/moc_optionsmodel.cpp \
qt/moc_overviewpage.cpp \
qt/moc_paymentserver.cpp \
qt/moc_peertablemodel.cpp \
qt/moc_peertablesortproxy.cpp \
qt/moc_paymentserver.cpp \
qt/moc_proposalmodel.cpp \
qt/moc_proposalwizard.cpp \
qt/moc_psbtoperationsdialog.cpp \
qt/moc_qrdialog.cpp \
qt/moc_qrimagewidget.cpp \
Expand All @@ -91,7 +93,6 @@ QT_MOC_CPP = \
qt/moc_splashscreen.cpp \
qt/moc_trafficgraphwidget.cpp \
qt/moc_transactiondesc.cpp \
qt/moc_transactiondescdialog.cpp \
qt/moc_transactionfilterproxy.cpp \
qt/moc_transactionoverviewwidget.cpp \
qt/moc_transactiontablemodel.cpp \
Expand Down Expand Up @@ -134,9 +135,9 @@ BITCOIN_QT_H = \
qt/coincontroltreewidget.h \
qt/createwalletdialog.h \
qt/csvmodelwriter.h \
qt/descriptiondialog.h \
qt/editaddressdialog.h \
qt/governancelist.h \
qt/proposalwizard.h \
qt/guiconstants.h \
qt/guiutil.h \
qt/guiutil_font.h \
Expand All @@ -145,9 +146,9 @@ BITCOIN_QT_H = \
qt/macdockiconhandler.h \
qt/macnotificationhandler.h \
qt/macos_appnap.h \
qt/modaloverlay.h \
qt/masternodelist.h \
qt/mnemonicverificationdialog.h \
qt/modaloverlay.h \
qt/networkstyle.h \
qt/notificator.h \
qt/openuridialog.h \
Expand All @@ -157,6 +158,8 @@ BITCOIN_QT_H = \
qt/paymentserver.h \
qt/peertablemodel.h \
qt/peertablesortproxy.h \
qt/proposalmodel.h \
qt/proposalwizard.h \
qt/psbtoperationsdialog.h \
qt/qrdialog.h \
qt/qrimagewidget.h \
Expand All @@ -174,7 +177,6 @@ BITCOIN_QT_H = \
qt/trafficgraphdata.h \
qt/trafficgraphwidget.h \
qt/transactiondesc.h \
qt/transactiondescdialog.h \
qt/transactionfilterproxy.h \
qt/transactionoverviewwidget.h \
qt/transactionrecord.h \
Expand All @@ -189,36 +191,36 @@ BITCOIN_QT_H = \
qt/winshutdownmonitor.h

QT_RES_ICONS = \
qt/res/icons/dash.ico \
qt/res/icons/dash_testnet.ico \
qt/res/icons/dash.png \
qt/res/icons/warning.png \
qt/res/icons/address-book.png \
qt/res/icons/transaction0.png \
qt/res/icons/transaction1.png \
qt/res/icons/transaction2.png \
qt/res/icons/transaction3.png \
qt/res/icons/transaction4.png \
qt/res/icons/transaction5.png \
qt/res/icons/transaction_abandoned.png \
qt/res/icons/transaction_locked.png \
qt/res/icons/connect1_16.png \
qt/res/icons/connect2_16.png \
qt/res/icons/connect3_16.png \
qt/res/icons/connect4_16.png \
qt/res/icons/dash.ico \
qt/res/icons/dash.png \
qt/res/icons/dash_testnet.ico \
qt/res/icons/editcopy.png \
qt/res/icons/editpaste.png \
qt/res/icons/eye.png \
qt/res/icons/eye_minus.png \
qt/res/icons/eye_plus.png \
qt/res/icons/fontbigger.png \
qt/res/icons/fontsmaller.png \
qt/res/icons/hd_enabled.png \
qt/res/icons/lock_closed.png \
qt/res/icons/lock_open.png \
qt/res/icons/proxy.png \
qt/res/icons/remove.png \
qt/res/icons/synced.png \
qt/res/icons/fontbigger.png \
qt/res/icons/fontsmaller.png
qt/res/icons/transaction0.png \
qt/res/icons/transaction1.png \
qt/res/icons/transaction2.png \
qt/res/icons/transaction3.png \
qt/res/icons/transaction4.png \
qt/res/icons/transaction5.png \
qt/res/icons/transaction_abandoned.png \
qt/res/icons/transaction_locked.png \
qt/res/icons/warning.png

BITCOIN_QT_BASE_CPP = \
qt/appearancewidget.cpp \
Expand Down Expand Up @@ -258,14 +260,16 @@ BITCOIN_QT_WALLET_CPP = \
qt/coincontroldialog.cpp \
qt/coincontroltreewidget.cpp \
qt/createwalletdialog.cpp \
qt/descriptiondialog.cpp \
qt/editaddressdialog.cpp \
qt/governancelist.cpp \
qt/proposalwizard.cpp \
qt/masternodelist.cpp \
qt/mnemonicverificationdialog.cpp \
qt/openuridialog.cpp \
qt/overviewpage.cpp \
qt/paymentserver.cpp \
qt/proposalmodel.cpp \
qt/proposalwizard.cpp \
qt/psbtoperationsdialog.cpp \
qt/qrdialog.cpp \
qt/qrimagewidget.cpp \
Expand All @@ -276,7 +280,6 @@ BITCOIN_QT_WALLET_CPP = \
qt/sendcoinsentry.cpp \
qt/signverifymessagedialog.cpp \
qt/transactiondesc.cpp \
qt/transactiondescdialog.cpp \
qt/transactionfilterproxy.cpp \
qt/transactionoverviewwidget.cpp \
qt/transactionrecord.cpp \
Expand All @@ -301,50 +304,50 @@ QT_RES_IMAGES = \
qt/res/images/arrow_down_light.png \
qt/res/images/arrow_left_dark.png \
qt/res/images/arrow_left_light.png \
qt/res/images/arrow_right_dark.png \
qt/res/images/arrow_right_light.png \
qt/res/images/arrow_up_dark.png \
qt/res/images/arrow_up_light.png \
qt/res/images/arrow_light_down_normal.png \
qt/res/images/arrow_light_down_hover.png \
qt/res/images/arrow_light_left_normal.png \
qt/res/images/arrow_light_down_normal.png \
qt/res/images/arrow_light_left_hover.png \
qt/res/images/arrow_light_right_normal.png \
qt/res/images/arrow_light_left_normal.png \
qt/res/images/arrow_light_right_hover.png \
qt/res/images/arrow_light_up_normal.png \
qt/res/images/arrow_light_right_normal.png \
qt/res/images/arrow_light_up_hover.png \
qt/res/images/checkbox_normal_dark.png \
qt/res/images/checkbox_normal_hover_dark.png \
qt/res/images/checkbox_normal_disabled_dark.png \
qt/res/images/arrow_light_up_normal.png \
qt/res/images/arrow_right_dark.png \
qt/res/images/arrow_right_light.png \
qt/res/images/arrow_up_dark.png \
qt/res/images/arrow_up_light.png \
qt/res/images/checkbox_checked_dark.png \
qt/res/images/checkbox_checked_hover_dark.png \
qt/res/images/checkbox_checked_disabled_dark.png \
qt/res/images/checkbox_checked_disabled_light.png \
qt/res/images/checkbox_checked_hover_dark.png \
qt/res/images/checkbox_checked_hover_light.png \
qt/res/images/checkbox_checked_light.png \
qt/res/images/checkbox_normal_dark.png \
qt/res/images/checkbox_normal_disabled_dark.png \
qt/res/images/checkbox_normal_disabled_light.png \
qt/res/images/checkbox_normal_hover_dark.png \
qt/res/images/checkbox_normal_hover_light.png \
qt/res/images/checkbox_normal_light.png \
qt/res/images/checkbox_partly_checked_dark.png \
qt/res/images/checkbox_partly_checked_hover_dark.png \
qt/res/images/checkbox_partly_checked_disabled_dark.png \
qt/res/images/checkbox_normal_light.png \
qt/res/images/checkbox_normal_hover_light.png \
qt/res/images/checkbox_normal_disabled_light.png \
qt/res/images/checkbox_checked_light.png \
qt/res/images/checkbox_checked_hover_light.png \
qt/res/images/checkbox_checked_disabled_light.png \
qt/res/images/checkbox_partly_checked_light.png \
qt/res/images/checkbox_partly_checked_hover_light.png \
qt/res/images/checkbox_partly_checked_disabled_light.png \
qt/res/images/checkbox_partly_checked_hover_dark.png \
qt/res/images/checkbox_partly_checked_hover_light.png \
qt/res/images/checkbox_partly_checked_light.png \
qt/res/images/dash_logo_toolbar.png \
qt/res/images/dash_logo_toolbar_blue.png \
qt/res/images/radio_normal_dark.png \
qt/res/images/radio_normal_hover_dark.png \
qt/res/images/radio_checked_dark.png \
qt/res/images/radio_checked_hover_dark.png \
qt/res/images/radio_normal_disabled_dark.png \
qt/res/images/radio_checked_disabled_dark.png \
qt/res/images/radio_normal_light.png \
qt/res/images/radio_normal_hover_light.png \
qt/res/images/radio_checked_light.png \
qt/res/images/radio_checked_disabled_light.png \
qt/res/images/radio_checked_hover_dark.png \
qt/res/images/radio_checked_hover_light.png \
qt/res/images/radio_checked_light.png \
qt/res/images/radio_normal_dark.png \
qt/res/images/radio_normal_disabled_dark.png \
qt/res/images/radio_normal_disabled_light.png \
qt/res/images/radio_checked_disabled_light.png \
qt/res/images/radio_normal_hover_dark.png \
qt/res/images/radio_normal_hover_light.png \
qt/res/images/radio_normal_light.png \
qt/res/images/splash.png

QT_RES_CSS = \
Expand Down
Loading
Loading