ENH/TST: tougher restrictions on array_api_strict #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
changed the title
crusaderky
force-pushed
the
array_api_strictest
branch
4 times, most recently
from
a91d82c to
dd1de30
Compare
lucascolley
reviewed
Mar 27, 2025
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
high-level question before reviewing this: what is the motivation for keeping both ARRAY_API_STRICT and ARRAY_API_STRICTEST, rather than just only using the strictest version?
crusaderky
force-pushed
the
array_api_strictest
branch
from
dd1de30 to
c853b58
Compare
Contributor
Author
ARRAY_API_STRICT follows different, more performant code paths. You can see it both in |
lucascolley
approved these changes
Mar 27, 2025
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
thanks Guido, looks pretty much there!
NeilGirdhar
pushed a commit
to NeilGirdhar/array-api-extra
that referenced
this pull request
Apr 2, 2025
* ENH: tougher restrictions on array_api_strict * Clean up Backend tests * Code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuniquesupport for unknown backends withoutunique_counts- for example,marraywrapping around JAX.apply_wheresupport for unknown backends without boolean index assignment - again for examplemarraywrapping around JAX (but see Array APIcapabilities()are incorrect jax-ml/jax#27418)apply_wheresupport for sparse arraysUpstream issues
capabilities()are incorrect jax-ml/jax#27418any()fails when wrapping JAX and PyTorch mdhaber/marray#99