Skip to content

Commit 3d70b56

Browse files
committed
incorporating changes from review comments
1 parent 70fedd2 commit 3d70b56

File tree

5 files changed

+9
-13
lines changed

5 files changed

+9
-13
lines changed

saphana-plugin/src/main/java/io/cdap/plugin/saphana/SapHanaConstants.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,4 @@ public class SapHanaConstants {
2424
public static final String SAPHANA_CONNECTION_STRING_FORMAT = "jdbc:sap://%s:%s/";
2525
public static final String PLUGIN_NAME = "SapHana";
2626

27-
private SapHanaConstants() {
28-
throw new AssertionError("Should not instantiate static utility class.");
29-
}
30-
3127
}

saphana-plugin/widgets/SapHana-action.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"metadata": {
3-
"spec-version": "1.0"
3+
"spec-version": "1.6"
44
},
55
"display-name": "SAP HANA Execute",
66
"configuration-groups": [
@@ -37,7 +37,7 @@
3737
"name": "database"
3838
},
3939
{
40-
"widget-type": "textarea",
40+
"widget-type": "sql-editor",
4141
"label": "Database Command",
4242
"name": "query"
4343
}

saphana-plugin/widgets/SapHana-batchsink.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"metadata": {
3-
"spec-version": "1.0"
3+
"spec-version": "1.6"
44
},
55
"display-name": "SAP HANA",
66
"configuration-groups": [

saphana-plugin/widgets/SapHana-batchsource.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"metadata": {
3-
"spec-version": "1.0"
3+
"spec-version": "1.6"
44
},
55
"display-name": "SAP HANA",
66
"configuration-groups": [
@@ -45,7 +45,7 @@
4545
"name": "database"
4646
},
4747
{
48-
"widget-type": "textarea",
48+
"widget-type": "sql-editor",
4949
"label": "Import Query",
5050
"name": "importQuery",
5151
"widget-attributes": {
@@ -81,12 +81,12 @@
8181
}
8282
},
8383
{
84-
"widget-type": "textbox",
84+
"widget-type": "input-field-selector",
8585
"label": "Split-By Field Name",
8686
"name": "splitBy"
8787
},
8888
{
89-
"widget-type": "textbox",
89+
"widget-type": "number",
9090
"label": "Number of Splits to Generate",
9191
"name": "numSplits",
9292
"widget-attributes": {

saphana-plugin/widgets/SapHana-postaction.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"metadata": {
3-
"spec-version": "1.0"
3+
"spec-version": "1.6"
44
},
55
"configuration-groups": [
66
{
@@ -49,7 +49,7 @@
4949
"name": "database"
5050
},
5151
{
52-
"widget-type": "textarea",
52+
"widget-type": "sql-editor",
5353
"label": "Query",
5454
"name": "query",
5555
"widget-attributes": {

0 commit comments

Comments
 (0)