Cloudfetch: Allow configuration of httpclient for cloudfetch #308
+152
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multimo
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jadewang-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
Collaborator
|
Thanks for making the clean fix, @Multimo ! One minor comment on renaming. |
connector.go
Outdated
| } | ||
|
|
||
| // WithCloudFetchHTTPClient allows a custom http client to be used for cloud fetch. Default is http.DefaultClient. | ||
| func WithCloudFetchHTTPClient(httpClient *http.Client) ConnOption { |
Collaborator
There was a problem hiding this comment.
Can we rename this to withHTTPClient ?
Collaborator
There was a problem hiding this comment.
Also, can you work with WithTransport option in this file for the private network use-case?
Author
There was a problem hiding this comment.
An alternative, until you merge the two http clients, could be to use have the WithTransport add to the CloudFetchConfig also. I can update to do this if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues
Hello, as per issue looking for ways to modify the transport layer of the httpclient that cloudfetch uses. Happy to go another way to solving this, this just seamed like the simplest. Thanks for your work on the driver, its been very useful 👍