Remove interface 42 dependence

Author: CBroz1

element_array_ephys/ephys_report.py

@@ -1,9 +1,10 @@
-import pathlib
 import datetime
-import datajoint as dj
+import pathlib
 import typing as T
+from uuid import UUID
 
-from element_interface.utils import insert1_skip_full_duplicates
+import datajoint as dj
+from element_interface.utils import dict_to_uuid
 
 schema = dj.schema()
 
@@ -102,9 +103,9 @@ class UnitLevelReport(dj.Computed):
     def make(self, key):
 
         from .plotting.unit_level import (
-            plot_waveform,
             plot_auto_correlogram,
             plot_depth_waveforms,
+            plot_waveform,
         )
 
         sampling_rate = (ephys.EphysRecording & key).fetch1(
@@ -145,9 +146,14 @@ class QualityMetricCutoffs(dj.Lookup):
     amplitude_cutoff_maximum=null : float # Defualt null, no cutoff applied
     presence_ratio_minimum=null   : float # Defualt null, no cutoff applied
     isi_violations_maximum=null   : float # Defualt null, no cutoff applied
+    cutoffs_hash: uuid
+    unique index (cutoffs_hash)
     """
 
-    contents = [(0, None, None, None), (1, 0.1, 0.9, 0.5)]
+    contents = [
+        (0, None, None, None, UUID("5d835de1-e1af-1871-d81f-d12a9702ff5f")),
+        (1, 0.1, 0.9, 0.5, UUID("f74ccd77-0b3a-2bf8-0bfd-ec9713b5dca8")),
+    ]
 
     @classmethod
     def insert_new_cutoffs(
@@ -157,18 +163,38 @@ def insert_new_cutoffs(
         presence_ratio_minimum: float = None,
         isi_violations_maximum: float = None,
     ):
-        if not cutoffs_id:
+        if cutoffs_id is None:
             cutoffs_id = (dj.U().aggr(cls, n="max(cutoffs_id)").fetch1("n") or 0) + 1
 
-        insert1_skip_full_duplicates(  # depends on element-interface/pull/43
-            cls,
-            dict(
-                cutoffs_id=cutoffs_id,
-                amplitude_cutoff_maximum=amplitude_cutoff_maximum,
-                presence_ratio_minimum=presence_ratio_minimum,
-                isi_violations_maximum=isi_violations_maximum,
-            ),
-        )
+        param_dict = {
+            "amplitude_cutoff_maximum": amplitude_cutoff_maximum,
+            "presence_ratio_minimum": presence_ratio_minimum,
+            "isi_violations_maximum": isi_violations_maximum,
+        }
+        param_hash = dict_to_uuid(param_dict)
+        param_query = cls & {"cutoffs_hash": param_hash}
+
+        if param_query:  # If the specified cutoff set already exists
+            existing_paramset_idx = param_query.fetch1("cutoffs_id")
+            if (
+                existing_paramset_idx == cutoffs_id
+            ):  # If the existing set has the same id: job done
+                return
+            # If not same name: human err, adding the same set with different name
+            else:
+                raise dj.DataJointError(
+                    f"The specified param-set already exists"
+                    f" - with paramset_idx: {existing_paramset_idx}"
+                )
+        else:
+            if {"cutoffs_id": cutoffs_id} in cls.proj():
+                raise dj.DataJointError(
+                    f"The specified cuttoffs_id {cutoffs_id} already exists,"
+                    f" please pick a different one."
+                )
+            cls.insert1(
+                {"cutoffs_id": cutoffs_id, **param_dict, "cutoffs_hash": param_hash}
+            )
 
 
 @schema