-
Notifications
You must be signed in to change notification settings - Fork 16
Switch to boto3 #142
Copy link
Copy link
Open
Description
It is to happen for datalad core in coming minor release
- RF: Drop boto for boto3 datalad#7575
which would break compatibility with datalad-crawler by removingget_key_urlwhich operates on boto's construct AFAIK:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datalad_crawler/nodes/s3.py:21: in <module>
53
from datalad.support.s3 import get_key_url
54
E ImportError: cannot import name 'get_key_url' from 'datalad.support.s3' (/home/runner/work/datalad/datalad/datalad/support/s3.py)
and also there is some direct use of boto here:
datalad_crawler/nodes/s3.py:from boto.s3.key import Key
datalad_crawler/nodes/s3.py:from boto.s3.prefix import Prefix
datalad_crawler/nodes/s3.py:from boto.s3.deletemarker import DeleteMarker
setup.py: 'boto', # used directly by datalad_crawler/nodes/s3.py
so meanwhile we would need to restrict for crawler to have datalad < 1.1.0
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels