Dash public api actions #3095
Dash public api actions #3095
Conversation
|
|
📦 Statoscope quick diff with main-branch: ⏱ Build time: -1.3 sec (-2.4%) ⚖️ Initial size: -0.04 kb (0%) 🕵️ Validation errors: 0 Full Statoscope report could be found here |
|
|
|
|
||
| const createDashData = dataSchema | ||
| .partial({tabs: true, salt: true}) | ||
| .omit({schemeVersion: true, counter: true}); |
There was a problem hiding this comment.
i think there is no need to pass counter on create, because we can calculate it based on tabs
UPD. I changed my mind and now I think it's worth passing all the parameters, and make them required
There was a problem hiding this comment.
counter is optional for create
There was a problem hiding this comment.
made everything required for now as we discussed
| return { | ||
| salt, | ||
| counter: 2, | ||
| tabs: [ | ||
| { | ||
| id: hashids.encode(1), | ||
| title: i18n('value_default', {index: 1}), | ||
| items: [], | ||
| layout: [], | ||
| aliases: {}, | ||
| connections: [], | ||
| }, | ||
| ], | ||
| }; | ||
| } |
There was a problem hiding this comment.
I'm not sure that salt, counter and tabs must be optional
Maybe we can make it required
It seems weird that you don't have to pass some of these parameters
There was a problem hiding this comment.
We all agreed that it can be optional for create, but not for update.
There was a problem hiding this comment.
made everything required as we discussed
| return { | ||
| salt, | ||
| counter: 2, | ||
| tabs: [ | ||
| { | ||
| id: hashids.encode(1), | ||
| title: i18n('value_default', {index: 1}), | ||
| items: [], | ||
| layout: [], | ||
| aliases: {}, | ||
| connections: [], | ||
| }, | ||
| ], | ||
| }; | ||
| } |
There was a problem hiding this comment.
We all agreed that it can be optional for create, but not for update.
| import {DASH_VERSION_1} from '../../schemas/dash/dash-v1'; | ||
| import type {CreateDashV1Result, DashV1} from '../../types'; | ||
|
|
||
| const processTabs = ({ |
There was a problem hiding this comment.
Don't like naming (with this name I have strong association with editor tabs processing)
There was a problem hiding this comment.
is prepareTabs or prepareTabsParams okay?
|
|
||
| await typedApi.us._deleteUSEntry({ | ||
| entryId: dashboardId, | ||
| lockToken, |
There was a problem hiding this comment.
lockToken is optional in scheme now. As far as I remember, if we don't have token we need to create it before pass it to us
There was a problem hiding this comment.
You mean that we need default value for lockToken?
I discussed this with @imsitnikov, and he says that lockToken must be optional
|
|
||
| const createDashData = dataSchema | ||
| .partial({tabs: true, salt: true}) | ||
| .omit({schemeVersion: true, counter: true}); |
There was a problem hiding this comment.
counter is optional for create
No description provided.