Skip to content

Commit f8e0a91

Browse files
F0x06David
authored andcommitted
FRotator arguments order should be pitch yaw roll instead of roll pitch yaw
1 parent 4b5da5b commit f8e0a91

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Source/UnrealEnginePython/Private/Wrappers/UEPyFRotator.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ static PyGetSetDef ue_PyFRotator_getseters[] = {
8989

9090
static PyObject *ue_PyFRotator_str(ue_PyFRotator *self)
9191
{
92-
return PyUnicode_FromFormat("<unreal_engine.FRotator {'roll': %S, 'pitch': %S, 'yaw': %S}>",
93-
PyFloat_FromDouble(self->rot.Roll), PyFloat_FromDouble(self->rot.Pitch), PyFloat_FromDouble(self->rot.Yaw));
92+
return PyUnicode_FromFormat("<unreal_engine.FRotator {'pitch': %S, 'yaw': %S, 'roll': %S}>",
93+
PyFloat_FromDouble(self->rot.Pitch), PyFloat_FromDouble(self->rot.Yaw), PyFloat_FromDouble(self->rot.Roll));
9494
}
9595

9696
PyTypeObject ue_PyFRotatorType = {
@@ -211,11 +211,11 @@ static Py_ssize_t ue_py_frotator_seq_length(ue_PyFRotator *self) {
211211
static PyObject *ue_py_frotator_seq_item(ue_PyFRotator *self, Py_ssize_t i) {
212212
switch (i) {
213213
case 0:
214-
return PyFloat_FromDouble(self->rot.Roll);
215-
case 1:
216214
return PyFloat_FromDouble(self->rot.Pitch);
217-
case 2:
215+
case 1:
218216
return PyFloat_FromDouble(self->rot.Yaw);
217+
case 2:
218+
return PyFloat_FromDouble(self->rot.Roll);
219219
}
220220
return PyErr_Format(PyExc_IndexError, "FRotator has only 3 items");
221221
}
@@ -232,7 +232,7 @@ static int ue_py_frotator_init(ue_PyFRotator *self, PyObject *args, PyObject *kw
232232
}
233233
}
234234

235-
if (!PyArg_ParseTuple(args, "|fff", &roll, &pitch, &yaw))
235+
if (!PyArg_ParseTuple(args, "|fff", &pitch, &yaw, &roll))
236236
return -1;
237237

238238
if (PyTuple_Size(args) == 1) {
@@ -297,7 +297,7 @@ bool py_ue_rotator_arg(PyObject *args, FRotator &rot) {
297297
}
298298

299299
float pitch, yaw, roll;
300-
if (!PyArg_ParseTuple(args, "fff", &roll, &pitch, &yaw))
300+
if (!PyArg_ParseTuple(args, "fff", &pitch, &yaw, &roll))
301301
return false;
302302
rot.Pitch = pitch;
303303
rot.Yaw = yaw;

0 commit comments

Comments
 (0)