Improve Wi-Fi configuration in settings UI

- Remove debug code from server.py
- Fix Wi-Fi network save process by using proper wifi.save_networks() function
- Add unsaved changes indicator to Save button in settings UI
- Disable Save button when there are no changes to save

Author: dbieber

gonotego/settings-server/src/App.tsx

@@ -55,6 +55,9 @@ const SettingsUI = () => {
     CUSTOM_COMMAND_PATHS: [],
   });
 
+  // Keep track of the original settings to detect changes
+  const [originalSettings, setOriginalSettings] = useState({});
+  
   const [newWifiNetwork, setNewWifiNetwork] = useState({
     ssid: '',
     psk: ''
@@ -90,10 +93,14 @@ const SettingsUI = () => {
         }, {});
 
         // Update settings state with fetched data
-        setSettings(prev => ({
-          ...prev,
+        const updatedSettings = {
+          ...settings,
           ...validSettings
-        }));
+        };
+        setSettings(updatedSettings);
+        
+        // Store the original settings to detect changes
+        setOriginalSettings(JSON.parse(JSON.stringify(updatedSettings)));
       } catch (error) {
         console.error('Error fetching settings:', error);
         setLoadError(true);
@@ -105,6 +112,20 @@ const SettingsUI = () => {
     fetchSettings();
   }, []);
 
+  // Function to detect if there are unsaved changes
+  const hasUnsavedChanges = () => {
+    // Check if the settings object has the same structure as originalSettings
+    if (Object.keys(originalSettings).length === 0) return false;
+    
+    // Compare original and current settings using deep comparison
+    try {
+      return JSON.stringify(settings) !== JSON.stringify(originalSettings);
+    } catch (e) {
+      // If comparison fails (e.g., circular references), default to true
+      return true;
+    }
+  };
+
   const handleChange = (key, value) => {
     setSettings(prev => ({
       ...prev,
@@ -135,6 +156,10 @@ const SettingsUI = () => {
       }
 
       setSaveStatus('saved');
+      
+      // Update the original settings after saving
+      setOriginalSettings(JSON.parse(JSON.stringify(settings)));
+      
       setTimeout(() => setSaveStatus(null), 2000);
     } catch (error) {
       console.error('Error saving settings:', error);
@@ -736,15 +761,15 @@ const SettingsUI = () => {
           )}
           <Button
             onClick={handleSave}
-            className="w-32"
-            disabled={saveStatus === 'saving'}
+            className={`w-32 ${hasUnsavedChanges() ? 'bg-blue-600 hover:bg-blue-700' : 'bg-slate-300 hover:bg-slate-400'}`}
+            disabled={saveStatus === 'saving' || !hasUnsavedChanges()}
           >
             {saveStatus === 'saving' ? (
               'Saving...'
             ) : (
               <>
                 <Save className="h-4 w-4 mr-2" />
-                Save
+                {hasUnsavedChanges() ? 'Save *' : 'Save'}
               </>
             )}
           </Button>

gonotego/settings/server.py

@@ -155,25 +155,13 @@ def do_GET(self):
   def do_POST(self):
     """Handle POST requests."""
     parsed_path = urlparse(self.path)
-
-    # Early debug log to see if we're getting to this point
-    with open('/tmp/wifi_debug_start.log', 'a') as f:
-      f.write(f"POST request received to {parsed_path.path}\n")
-
     if parsed_path.path == "/api/settings":
       try:
         # Read the request body
         content_length = int(self.headers["Content-Length"])
         post_data = self.rfile.read(content_length).decode("utf-8")
         settings_data = json.loads(post_data)
 
-        # Write all settings being processed to debug file
-        with open('/tmp/wifi_debug.log', 'a') as f:
-          f.write("===== SETTINGS UPDATE =====\n")
-          for k, v in settings_data.items():
-            f.write(f"Key: {k}, Value type: {type(v)}, Value: {v}\n")
-          f.write("========================\n")
-            
         # Update settings
         for key, value in settings_data.items():
           # Skip masked values - we don't want to overwrite with placeholder text
@@ -189,9 +177,6 @@ def do_POST(self):
             # If we're updating WiFi networks, save networks and update the wpa_supplicant.conf file
             if key == 'WIFI_NETWORKS':
               try:
-                # Write debug info to a file that can be checked later
-                with open('/tmp/wifi_debug.log', 'a') as f:
-                  f.write(f"WIFI_NETWORKS value type: {type(value)}, value: {value}\n")
                 # Parse the value to ensure it's in the correct format
                 if isinstance(value, str):
                   networks = json.loads(value)