Skip to content

Commit 9e618f4

Browse files
dbieberclaude
andcommitted
Inline simpler scripts back into build.yml and add trailing newlines
Changes: - Inline setup_python_env.sh back into build.yml - Inline setup_bash_history.sh back into build.yml - Remove the inlined script files - Add trailing newlines to all template files - Update README to reflect removed scripts This keeps the more complex configuration scripts separate while avoiding over-abstraction for simpler operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 847300a commit 9e618f4

File tree

11 files changed

+22
-32
lines changed

11 files changed

+22
-32
lines changed

.github/scripts/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ This directory contains scripts used in the build process for creating the GoNot
66

77
- `setup_wifi_ap.sh`: Sets up the WiFi access point for the GoNoteGo device
88
- `setup_boot.sh`: Configures the system to start GoNoteGo on boot and sets initial system settings
9-
- `setup_python_env.sh`: Sets up the Python environment for GoNoteGo
109
- `install_geckodriver.sh`: Installs the geckodriver needed for browser automation
11-
- `setup_bash_history.sh`: Sets up useful commands in bash history for debugging purposes
1210

1311
These scripts are used by the GitHub workflow defined in `.github/workflows/build.yml`.

.github/scripts/setup_bash_history.sh

Lines changed: 0 additions & 4 deletions
This file was deleted.

.github/scripts/setup_python_env.sh

Lines changed: 0 additions & 16 deletions
This file was deleted.

.github/templates/bash_history

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ nano /home/pi/code/github/dbieber/GoNoteGo/gonotego/settings/secure_settings.py
2525
/home/pi/code/github/dbieber/GoNoteGo/env/bin/supervisord -c /home/pi/code/github/dbieber/GoNoteGo/gonotego/supervisord.conf
2626
/home/pi/code/github/dbieber/GoNoteGo/env/bin/supervisorctl -u go -p notego status
2727
/home/pi/code/github/dbieber/GoNoteGo/env/bin/supervisorctl -u go -p notego restart all
28-
cd /home/pi/code/github/dbieber/GoNoteGo/
28+
cd /home/pi/code/github/dbieber/GoNoteGo/

.github/templates/dhcpcd.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,4 +58,4 @@ slaac private
5858
# Interface for Go Note Go Access Point
5959
interface uap0
6060
static ip_address=192.168.4.1/24
61-
nohook wpa_supplicant
61+
nohook wpa_supplicant

.github/templates/dnsmasq.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
interface=uap0
2-
dhcp-range=192.168.4.2,192.168.4.20,255.255.255.0,24h
2+
dhcp-range=192.168.4.2,192.168.4.20,255.255.255.0,24h

.github/templates/hostapd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
DAEMON_CONF="/etc/hostapd/hostapd.conf"
1+
DAEMON_CONF="/etc/hostapd/hostapd.conf"

.github/templates/hostapd.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ wpa=2
1010
wpa_passphrase=swingset
1111
wpa_key_mgmt=WPA-PSK
1212
wpa_pairwise=TKIP
13-
rsn_pairwise=CCMP
13+
rsn_pairwise=CCMP

.github/templates/sysctl.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
net.ipv4.ip_forward=1
1+
net.ipv4.ip_forward=1

.github/templates/uap0.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ ExecStartPost=/sbin/ifconfig uap0 up
1111
ExecStop=/sbin/iw dev uap0 del
1212

1313
[Install]
14-
WantedBy=multi-user.target
14+
WantedBy=multi-user.target

0 commit comments

Comments
 (0)