Update Roam uploader to handle login failures gracefully

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

Author: dbieber

gonotego/uploader/roam/roam_uploader.py

@@ -200,9 +200,11 @@ def new_session(self):
 
   def upload(self, note_events):
     browser = self.get_browser()
-    if not browser.go_graph(settings.get('ROAM_GRAPH')):
-      # Failed to go to graph - return False to indicate failure
-      print("Failed to access Roam graph. Will retry notes later.")
+    in_graph = browser.go_graph(settings.get('ROAM_GRAPH'))
+    if not in_graph
+      print("Failed to access Roam graph. Aborting upload.")
+      browser.screenshot('screenshot-go_graph-failure.png')
+      flush()
       return False
 
     time.sleep(0.5)
@@ -240,6 +242,11 @@ def upload(self, note_events):
         else:
           parent_uid = self.session_uid
         block_uid = browser.create_child_block(parent_uid, text)
+        if not block_uid:
+          print('create_child_block did not yield a block_uid. Aborting upload.')
+          browser.screenshot('screenshot-create_child_block-failure.png')
+          flush()
+          return False
         self.last_note_uid = block_uid
         print(f'Inserted: "{text}" at block (({block_uid}))')
         if has_audio:

gonotego/uploader/runner.py

@@ -94,25 +94,17 @@ def main():
       status.set(Status.UPLOADER_ACTIVE, True)
       # TODO(dbieber): Allow uploader to yield note events as it finishes them.
       # So that if it fails midway, we can still mark the completed events as done.
-      try:
-        upload_success = uploader.upload(note_events)
-        # For older uploaders that don't return a value, assume success
-        if upload_success is None:
-          upload_success = True
-      except Exception as e:
-        print(f"Error during upload: {e}")
-        upload_success = False
-      
-      if upload_success:
+      upload_successful = uploader.upload(note_events)
+      if upload_successful:
         last_upload = time.time()
         print('Uploaded.')
-        # Only commit note events if upload was successful
-        for note_event_bytes in note_event_bytes_list:
-          note_events_queue.commit(note_event_bytes)
       else:
-        print('Upload failed. Will retry notes later.')
-        
+        print('Upload unsuccessful.')
+
       status.set(Status.UPLOADER_ACTIVE, False)
+      if upload_successful:
+        for note_event_bytes in note_event_bytes_list:
+          note_events_queue.commit(note_event_bytes)
 
     if last_upload and time.time() - last_upload > 600:
       # X minutes have passed since the last upload.