Fix issue with Roam uploader marking notes as uploaded when login fails (#114)

* Fix issue with Roam uploader marking notes as uploaded when login fails

When 'Failed to go to graph. No retries left.' occurs, we now prevent notes from being marked as uploaded.
The uploader now returns a success/failure status, and the runner only marks notes as committed if the upload succeeds.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

* Update Roam uploader to handle login failures gracefully

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

* Fix syntax error in roam_uploader.py

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

* Add return True to all other uploaders for consistency

Make all uploader.upload() methods return a success value to be compatible
with the changes in runner.py for handling upload failures.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

Author: dbieber

gonotego/uploader/email/email_uploader.py

@@ -37,6 +37,7 @@ def upload(self, note_events):
         with open(DRAFT_FILENAME, 'a') as f:
           f.write(line + '\n')
         self.last_indent_level = self.indent_level
+    return True
 
   def handle_inactivity(self):
     self.end_session()

gonotego/uploader/ideaflow/ideaflow_uploader.py

@@ -105,6 +105,7 @@ def upload(self, note_events):
           audio_url = blob_uploader.upload_blob(note_event.audio_filepath, client)
           text = f'{text} #unverified-transcription ({audio_url})'
         browser.insert_note(text)
+    return True
 
   def handle_inactivity(self):
     self.close_browser()

gonotego/uploader/mem/mem_uploader.py

@@ -34,6 +34,7 @@ def upload(self, note_events):
         else:
           is_read = True
         upload_mem(text, is_read=is_read)
+    return True
 
   def handle_inactivity(self):
     pass

gonotego/uploader/notion/notion_uploader.py

@@ -84,6 +84,7 @@ def upload(self, note_events):
           url = blob_uploader.upload_blob(note_event.audio_filepath, client)
           blocks.append(make_audio_block(url))
     append_notes(blocks, page_id=self.current_page_id)
+    return True
 
   def handle_inactivity(self):
     self.current_page_id = None

gonotego/uploader/remnote/remnote_uploader.py

@@ -42,6 +42,7 @@ def upload(self, note_events):
         if note_event.audio_filepath and os.path.exists(note_event.audio_filepath):
           url = blob_uploader.upload_blob(note_event.audio_filepath, client)
           create_rem(url, edit_later=False, parent_id=rem_id)
+    return True
 
   def handle_inactivity(self):
     pass

gonotego/uploader/roam/roam_uploader.py

@@ -200,7 +200,13 @@ def new_session(self):
 
   def upload(self, note_events):
     browser = self.get_browser()
-    browser.go_graph(settings.get('ROAM_GRAPH'))
+    in_graph = browser.go_graph(settings.get('ROAM_GRAPH'))
+    if not in_graph:
+      print("Failed to access Roam graph. Aborting upload.")
+      browser.screenshot('screenshot-go_graph-failure.png')
+      flush()
+      return False
+      
     time.sleep(0.5)
     browser.screenshot('screenshot-graph-later.png')
     browser.execute_helper_js()
@@ -236,6 +242,11 @@ def upload(self, note_events):
         else:
           parent_uid = self.session_uid
         block_uid = browser.create_child_block(parent_uid, text)
+        if not block_uid:
+          print('create_child_block did not yield a block_uid. Aborting upload.')
+          browser.screenshot('screenshot-create_child_block-failure.png')
+          flush()
+          return False
         self.last_note_uid = block_uid
         print(f'Inserted: "{text}" at block (({block_uid}))')
         if has_audio:
@@ -246,6 +257,8 @@ def upload(self, note_events):
             browser.create_child_block(block_uid, embed_text)
 
       flush()
+    
+    return True
 
   def handle_inactivity(self):
     self.end_session()

gonotego/uploader/runner.py

@@ -94,13 +94,17 @@ def main():
       status.set(Status.UPLOADER_ACTIVE, True)
       # TODO(dbieber): Allow uploader to yield note events as it finishes them.
       # So that if it fails midway, we can still mark the completed events as done.
-      uploader.upload(note_events)
-      last_upload = time.time()
-      print('Uploaded.')
-      status.set(Status.UPLOADER_ACTIVE, False)
+      upload_successful = uploader.upload(note_events)
+      if upload_successful:
+        last_upload = time.time()
+        print('Uploaded.')
+      else:
+        print('Upload unsuccessful.')
 
-    for note_event_bytes in note_event_bytes_list:
-      note_events_queue.commit(note_event_bytes)
+      status.set(Status.UPLOADER_ACTIVE, False)
+      if upload_successful:
+        for note_event_bytes in note_event_bytes_list:
+          note_events_queue.commit(note_event_bytes)
 
     if last_upload and time.time() - last_upload > 600:
       # X minutes have passed since the last upload.