Fix Wi-Fi network configuration in settings server and improve UI (#103)

* Fix Wi-Fi network configuration in settings server

The settings UI was correctly updating Wi-Fi networks in Redis, but not properly calling wifi.save_networks() which ensures proper handling before updating wpa_supplicant configuration.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

* Add additional debugging for Wi-Fi configuration issue

* Simplify debugging by removing try-except blocks

* Improve Wi-Fi configuration in settings UI

- Remove debug code from server.py
- Fix Wi-Fi network save process by using proper wifi.save_networks() function
- Add unsaved changes indicator to Save button in settings UI
- Disable Save button when there are no changes to save

* Refactor WiFi settings saving to avoid redundant calls

* Simplify WiFi network handling in settings server

* Pass value directly to save_networks without JSON parsing

Author: dbieber

gonotego/settings-server/src/App.tsx

@@ -55,6 +55,9 @@ const SettingsUI = () => {
     CUSTOM_COMMAND_PATHS: [],
   });
 
+  // Keep track of the original settings to detect changes
+  const [originalSettings, setOriginalSettings] = useState({});
+  
   const [newWifiNetwork, setNewWifiNetwork] = useState({
     ssid: '',
     psk: ''
@@ -90,10 +93,14 @@ const SettingsUI = () => {
         }, {});
 
         // Update settings state with fetched data
-        setSettings(prev => ({
-          ...prev,
+        const updatedSettings = {
+          ...settings,
           ...validSettings
-        }));
+        };
+        setSettings(updatedSettings);
+        
+        // Store the original settings to detect changes
+        setOriginalSettings(JSON.parse(JSON.stringify(updatedSettings)));
       } catch (error) {
         console.error('Error fetching settings:', error);
         setLoadError(true);
@@ -105,6 +112,20 @@ const SettingsUI = () => {
     fetchSettings();
   }, []);
 
+  // Function to detect if there are unsaved changes
+  const hasUnsavedChanges = () => {
+    // Check if the settings object has the same structure as originalSettings
+    if (Object.keys(originalSettings).length === 0) return false;
+    
+    // Compare original and current settings using deep comparison
+    try {
+      return JSON.stringify(settings) !== JSON.stringify(originalSettings);
+    } catch (e) {
+      // If comparison fails (e.g., circular references), default to true
+      return true;
+    }
+  };
+
   const handleChange = (key, value) => {
     setSettings(prev => ({
       ...prev,
@@ -135,6 +156,10 @@ const SettingsUI = () => {
       }
 
       setSaveStatus('saved');
+      
+      // Update the original settings after saving
+      setOriginalSettings(JSON.parse(JSON.stringify(settings)));
+      
       setTimeout(() => setSaveStatus(null), 2000);
     } catch (error) {
       console.error('Error saving settings:', error);
@@ -736,15 +761,15 @@ const SettingsUI = () => {
           )}
           <Button
             onClick={handleSave}
-            className="w-32"
-            disabled={saveStatus === 'saving'}
+            className={`w-32 ${hasUnsavedChanges() ? 'bg-blue-600 hover:bg-blue-700' : 'bg-slate-300 hover:bg-slate-400'}`}
+            disabled={saveStatus === 'saving' || !hasUnsavedChanges()}
           >
             {saveStatus === 'saving' ? (
               'Saving...'
             ) : (
               <>
                 <Save className="h-4 w-4 mr-2" />
-                Save
+                {hasUnsavedChanges() ? 'Save *' : 'Save'}
               </>
             )}
           </Button>

gonotego/settings/server.py

@@ -155,7 +155,6 @@ def do_GET(self):
   def do_POST(self):
     """Handle POST requests."""
     parsed_path = urlparse(self.path)
-
     if parsed_path.path == "/api/settings":
       try:
         # Read the request body
@@ -174,15 +173,14 @@ def do_POST(self):
             continue
 
           try:
-            settings.set(key, value)
-            # If we're updating WiFi networks, update the wpa_supplicant.conf file
+            # Handle WiFi networks specially
             if key == 'WIFI_NETWORKS':
-              try:
-                # Update wpa_supplicant configuration using the wifi module
-                wifi.update_wpa_supplicant_config()
-                wifi.reconfigure_wifi()
-              except Exception as e:
-                print(f"Error updating WiFi configuration: {e}")
+              wifi.save_networks(value)
+              wifi.update_wpa_supplicant_config()
+              wifi.reconfigure_wifi()
+            else:
+              # For all other settings, just use settings.set
+              settings.set(key, value)
           except Exception as e:
             print(f"Error setting {key}: {e}")