Skip to content

Fix template text extraction for Lang, Native name, and Nihongo templates #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhav45sktech wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix template text extraction for Lang, Native name, and Nihongo templates #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
339a568
updated chnages
vaibhav45sktech Jan 24, 2026
70fbc63
Fix template text extraction for lang, native name, and Nihongo templ…
vaibhav45sktech Jan 27, 2026
10f7858
Revert GenderExtractor.scala to upstream version
vaibhav45sktech Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion core/src/main/resources/templatetransform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,19 @@
},
"Lang":{
"transformer":"textNode",
"replace": "<br />$(3||)<br />"
"replace": "$(2||)"
},
"Native name|native_name":{
"transformer":"textNode",
"replace": "$(2||)"
},
"Nihongo2":{
"transformer":"textNode",
"replace": "$(1||)"
},
"Nihongo":{
"transformer":"textNode",
"replace": "$(2||)"
},
"Marriage":{
"transformer":"extractChildren",
Expand Down
20 changes: 20 additions & 0 deletions core/src/test/scala/org/dbpedia/extraction/wikiparser/TemplateTransformParserTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,26 @@ class TemplateTransformParserTest extends FlatSpec with Matchers
parse("en", "{{url|https://www.dji.com DJI.com}}") should be (Some("[https://www.dji.com]"))
}

it should "extract text from {{lang|nap|Abbrùzzu}}" in
{
parse("en", "{{lang|nap|Abbrùzzu}}") should be (Some("Abbrùzzu"))
}

it should "extract text from {{native name|nap|Abbrùzze}}" in
{
parse("en", "{{native name|nap|Abbrùzze}}") should be (Some("Abbrùzze"))
}

it should "extract text from {{Nihongo2|東京都}}" in
{
parse("en", "{{Nihongo2|東京都}}") should be (Some("東京都"))
}

it should "extract text from {{Nihongo|Tokyo|東京|Tōkyō}}" in
{
parse("en", "{{Nihongo|Tokyo|東京|Tōkyō}}") should be (Some("東京"))
}


private val wikiParser = WikiParser.getInstance()

Expand Down
Loading