Skip to content

MailboxIterface: Typehint to interface instead of implementation #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
homersimpsons wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MailboxIterface: Typehint to interface instead of implementation #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c84cf7
MailboxIterface: Typehint to interface instead of implementation
homersimpsons Jul 28, 2020
2480795
MailboxInterface: fix codestyle
homersimpsons Jul 28, 2020
8eaf38d
Mailbox: MessageIteratorInterface over MessageIterator
homersimpsons Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Mailbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ public function getStatus(int $flags = null): \stdClass
/**
* Bulk Set Flag for Messages.
*
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIterator|string $numbers Message numbers
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIteratorInterface|string $numbers Message numbers
*/
public function setFlag(string $flag, $numbers): bool
{
Expand All @@ -134,8 +134,8 @@ public function setFlag(string $flag, $numbers): bool
/**
* Bulk Clear Flag for Messages.
*
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIterator|string $numbers Message numbers
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIteratorInterface|string $numbers Message numbers
*/
public function clearFlag(string $flag, $numbers): bool
{
Expand Down Expand Up @@ -277,8 +277,8 @@ public function getThread(): array
/**
* Bulk move messages.
*
* @param array|MessageIterator|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to move the messages to
* @param array|MessageIteratorInterface|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to move the messages to
*
* @throws \Ddeboer\Imap\Exception\MessageMoveException
*/
Expand All @@ -292,8 +292,8 @@ public function move($numbers, MailboxInterface $mailbox): void
/**
* Bulk copy messages.
*
* @param array|MessageIterator|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to copy the messages to
* @param array|MessageIteratorInterface|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to copy the messages to
*
* @throws \Ddeboer\Imap\Exception\MessageCopyException
*/
Expand Down
16 changes: 8 additions & 8 deletions src/MailboxInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ public function getStatus(int $flags = null): \stdClass;
/**
* Bulk Set Flag for Messages.
*
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIterator|string $numbers Message numbers
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIteratorInterface|string $numbers Message numbers
*/
public function setFlag(string $flag, $numbers): bool;

/**
* Bulk Clear Flag for Messages.
*
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIterator|string $numbers Message numbers
* @param string $flag \Seen, \Answered, \Flagged, \Deleted, and \Draft
* @param array|MessageIteratorInterface|string $numbers Message numbers
*/
public function clearFlag(string $flag, $numbers): bool;

Expand Down Expand Up @@ -97,8 +97,8 @@ public function getThread(): array;
/**
* Bulk move messages.
*
* @param array|MessageIterator|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to move the messages to
* @param array|MessageIteratorInterface|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to move the messages to
*
* @throws \Ddeboer\Imap\Exception\MessageMoveException
*/
Expand All @@ -107,8 +107,8 @@ public function move($numbers, self $mailbox): void;
/**
* Bulk copy messages.
*
* @param array|MessageIterator|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to copy the messages to
* @param array|MessageIteratorInterface|string $numbers Message numbers
* @param MailboxInterface $mailbox Destination Mailbox to copy the messages to
*
* @throws \Ddeboer\Imap\Exception\MessageCopyException
*/
Expand Down