Inconsistency for Items

[Sophon]

Items have inconsistent values.

Some values are scaling values (so they have a scaling and a value) while some are string or a number.

For example, cosmetic_item_snowball has "Damage": 1. Meanwhile upgrade_arctic_blast has "Damage" : { "Value": 175, "Scale":...

I believe the most convenient solution would have all numeric values as scaling. Then the scaling can be 1 or whatever is needed.

[Sophon]

@hassayag
Alternative solution: have all numbers be raw numbers and then have nullable (so optional) scale value.
Readability would not be affected.
File size in theory should stay the same - numbers that are scaled will have that property, raw numbers that don't simply won't.

[hassayag]

@Sophon

numbers that are scaled will have that property, raw numbers that don't simply won't.

We already have scale values on items as far as I'm aware, implemented in the way you've described, but I might be misunderstanding you?

[Sophon]

@Sophon

numbers that are scaled will have that property, raw numbers that don't simply won't.

We already have scale values on items as far as I'm aware, implemented in the way you've described, but I might be misunderstanding you?

From the example, it's not the case.
What I meant was all would be a ScaledValue object but the scale, instead of being 1, would simply be absent.

[hassayag]

@Sophon

numbers that are scaled will have that property, raw numbers that don't simply won't.

We already have scale values on items as far as I'm aware, implemented in the way you've described, but I might be misunderstanding you?

From the example, it's not the case. What I meant was all would be a ScaledValue object but the scale, instead of being 1, would simply be absent.

An example of how you would like the output data to look might help

[Sophon]

Old:

"cosmetic_item_snowball": {
		"Name": "Snowball",
		"Cost": null,
		"Tier": null,
		"Activation": "InstantCast",
		"Slot": null,
		"Components": null,
		"TargetTypes": [
			"AllFriendly",
			"AllEnemy"
		],
		"ShopFilters": [
			"WeaponDamage"
		],
		"Damage": 1,

New:

"cosmetic_item_snowball": {
		"Name": "Snowball",
		"Cost": null,
		"Tier": null,
		"Activation": "InstantCast",
		"Slot": null,
		"Components": null,
		"TargetTypes": [
			"AllFriendly",
			"AllEnemy"
		],
		"ShopFilters": [
			"WeaponDamage"
		],
		"Damage": {
                         "Value": 1
                 }

Scaled numerical values stay the same.

[hassayag]

Old:

"cosmetic_item_snowball": {
		"Name": "Snowball",
		"Cost": null,
		"Tier": null,
		"Activation": "InstantCast",
		"Slot": null,
		"Components": null,
		"TargetTypes": [
			"AllFriendly",
			"AllEnemy"
		],
		"ShopFilters": [
			"WeaponDamage"
		],
		"Damage": 1,

New:

"cosmetic_item_snowball": {
		"Name": "Snowball",
		"Cost": null,
		"Tier": null,
		"Activation": "InstantCast",
		"Slot": null,
		"Components": null,
		"TargetTypes": [
			"AllFriendly",
			"AllEnemy"
		],
		"ShopFilters": [
			"WeaponDamage"
		],
		"Damage": {
                         "Value": 1
                 }

Scaled numerical values stay the same.

Ah I see now. Unfortunately I just don't think the minor benefit of this outweighs the migration cost right now