Compatibility issue with Minimal UI

[yjeroen]

Describe the bug
Minimal UI has the option to make the icons of the control sidebar smaller. Because combat-carousal uses nonconform HTML, this isn't working correctly.

To Reproduce
Enable both Minimal UI and combat-carousel.

<li class="scene-control " data-control="effects" data-canvas-layer="specials" title="Effect Controls">
            <i class="fas fa-magic"></i>
        </li>

<li class="scene-control" data-control="combat-carousel" title="Combat Carousel - click to toggle visibility, right-click to reset position">
    <img src="modules/combat-carousel/icons/empty-carousel-solid.svg" class="carousel-icon">
    <div class="wrapper">
        <i class="fas fa-caret-down collapse-indicator"></i>
    </div>
</li>

Normal HTML generated by Foundry API can be seen first. (example from FXMaster module)
Below that you can see the nonconform HTML generated by combat-carousal.

Expected behavior
Same API usage of adding control buttons as normal modules, so there is compatibility with Minimal UI and other modules that interact with the control sidebar.

Environment Info (please complete the following information):

• Foundry Version: v9
• CC Version: 0.2.5

[yjeroen]

Example of FXMaster adds its button via a hook:
https://gitlab.com/mesfoliesludiques/foundryvtt-fxmaster/-/blob/master/module/controls.js

[eclarke12]

Example of FXMaster adds its button via a hook: https://gitlab.com/mesfoliesludiques/foundryvtt-fxmaster/-/blob/master/module/controls.js

I can't add the button via the hook as the scene controls only accept font awesome icons. I will see what I can do about this in a future update.

[yjeroen]

I think the icon attribute adds it to the css html attribute? So use "combat-carousel-icon", or something. Then via your own css file you can stylise it to be your unique one. I might be wrong, mostly trying to help. :)

…

On 15 Jan 2022, 16:43 +0100, errational ***@***.***>, wrote: > Example of FXMaster adds its button via a hook: https://gitlab.com/mesfoliesludiques/foundryvtt-fxmaster/-/blob/master/module/controls.js I can't add the button via the hook as the scene controls only accept font awesome icons. I will see what I can do about this in a future update. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: ***@***.***>