-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
Follow-up to #40
Lines 171 to 172 in 757d099
| if (is.list(pscales) && !is.null(pscales[[i]]$lim)) | |
| pscales[[i]]$lim |
Prior to #40, there was some ambiguity in what is expected here -- the code says $lim but $limits was tested.
Mostly this seems like a documentation/consistency issue -- what values are allowed (design decision), and how is this documented.
If partial matching is allowed intentionally, this should be encoded explicitly, e.g. with [[pmatch("lim", names(pscales[[i]]))]] instead of $lim. Or perhaps just [["lim"]] to prevent partial matching.
Metadata
Metadata
Assignees
Labels
No labels