Using python package "lbg" instead of dpcloudserver will make the program easier to maintain

[xiaoyeqiannian]

"lbgcore" has been well encapsulated in the python library "lbg". We can replace the work of dpcloudserver in dpdispatcher by "import lbgcore". In the future, the new featcher and bug fixes of "lbg" will be updated to dpdispatcher in a more timely manner, what’s your opinion? @njzjz

[njzjz]

It looks good to me.

[njzjz]

Do you think it's a better idea to implement a plugin of dpdispatcher in the lbg package? For the possible implementation of the plugin, there is an example in dpdata.

[xiaoyeqiannian]

Good idea! If I implement a class similar to Format in dpdata on dpdispatcher to replace the Machine class, It will need to test in slurm, pbs and etc... Is there a more efficient method for testing?

[njzjz]

There have already been some tests for slurm and PBS.

Indeed, I don't think Machine needs to be changed. It has a plugin-like __init_subclass__ method.

dpdispatcher/dpdispatcher/machine.py

Lines 111 to 117 in f30244c

	def __init_subclass__(cls, **kwargs):
	super().__init_subclass__(**kwargs)
	alias = [cls.__name__, *cls.alias]
	for aa in alias:
	cls.subclasses_dict[aa] = cls
	cls.subclasses_dict[aa.lower()] = cls
	cls.options.add(cls.__name__)

However, we need to import these classes. Thus we just need this

ep_name = "dpdispatcher.plugins"  # or just dpdispatcher is good
try:
    eps = metadata.entry_points(group=ep_name)
except TypeError:
    eps = metadata.entry_points().get(ep_name, [])
for ep in eps:
    plugin = ep.load()

[xiaoyeqiannian]

oh, i see