fix(deps): update dependency @vscode/extension-telemetry to ^0.9.0 #83
Conversation
renovate
bot
requested review from
Artmann,
andyjakubowski,
jamesbhobbs and
saltenasl
as code owners
📝 WalkthroughWalkthroughThe pull request updates the top-level dependency Suggested reviewers
Pre-merge checks✅ Passed checks (5 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
from
6942d8b to
7123473
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=====================================
Coverage 73% 73%
=====================================
Files 577 577
Lines 47608 47608
Branches 5591 5591
=====================================
Hits 34856 34856
Misses 10922 10922
Partials 1830 1830 🚀 New features to boost your workflow:
|
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
5 times, most recently
from
3a9b7ba to
7f50b10
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json
[error] 1-1: Dependency graph inconsistency detected by npm ci: lock file diverges from package.json. Consider running 'npm install' to synchronize.
🪛 GitHub Actions: Copilot Setup Steps
package.json
[warning] 1-1: EBADENGINE: Unsupported engine. Required node >=22.17.0, current node v22.15.1. Consider upgrading Node to satisfy engine requirements.
🔇 Additional comments (2)
package.json (2)
2169-2169: Good: telemetry update addresses shutdown behavior concerns.The v0.8.4–v0.8.5 fixes for shutdown behavior and connection loss mentioned in release notes align with the linked issue #192742 about delayed process termination. The version bump is within reasonable semver bounds for a pre-1.0 package.
1-1: Review comment is incorrect.The package.json contains no Node version requirement—its
enginesfield specifies only"vscode": "^1.103.0". The CI workflow usesNODE_VERSION: 22.x, which is flexible and accepts any 22.x release. No mismatch exists.Likely an incorrect or invalid review comment.
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
3 times, most recently
from
4011ae1 to
9d45c75
Compare
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
from
9d45c75 to
73ef508
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CD
package.json
[warning] 1-1: Unsupported engine: current Node/v12+ (v22.15.1) does not satisfy required: node >=22.17.0 for @vscode/python-extension@1.0.6. Consider upgrading Node to at least 22.17.0.
🪛 GitHub Actions: CI
package.json
[warning] 1-1: EBADENGINE: Unsupported engine. The package '@vscode/python-extension@1.0.6' requires node >=22.17.0 (current: v22.15.1) and npm 10.9.2. Consider upgrading Node.js to satisfy engine requirements.
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
7 times, most recently
from
95841ca to
c8c0bdf
Compare
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
15 times, most recently
from
1b335af to
2ac94d1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
from
2ac94d1 to
aa3817b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Package Extension
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
3 times, most recently
from
8b9019c to
67c6bda
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
4 times, most recently
from
c715e40 to
f5643df
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
renovate
bot
force-pushed
the
renovate/vscode-extension-telemetry-0.x
branch
from
f5643df to
d4f950f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
| "@lumino/widgets": "^2.4.0", | ||
| "@nteract/messaging": "^7.0.0", | ||
| "@vscode/extension-telemetry": "^0.7.7", | ||
| "@vscode/extension-telemetry": "^0.9.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Critical: Dependency update blocked by unresolved breaking change—merge cannot proceed without telemetry wrapper fix.
The past review flagged that v0.8.0+ requires sendTelemetryErrorEvent() for errors, but src/platform/telemetry/index.ts still calls reporter.sendTelemetryEvent() with raw Error objects. This causes runtime failures. Confirm the wrapper has been updated to use the new API before merging.
🏁 Script executed:
#!/bin/bash
# Verify sendTelemetryErrorEvent is now used in telemetry wrapper
rg -n "sendTelemetryErrorEvent" --type ts src/
echo "---"
# Double-check error handling path in telemetry wrapper
rg -n "reporter\.sendTelemetryEvent" --type ts src/platform/telemetry/ -A3 -B3Length of output: 1091
Critical: Telemetry wrapper not updated for v0.8.0+ breaking change—merge blocked.
Verification confirms sendTelemetryErrorEvent() is not used anywhere in the codebase. Line 190 in src/platform/telemetry/index.ts still calls reporter.sendTelemetryEvent() in the error handling path, which v0.8.0+ no longer supports. Update the wrapper to use the new API before upgrading the dependency.
🤖 Prompt for AI Agents
In package.json around line 2492 and in src/platform/telemetry/index.ts
(referencing line ~190), the telemetry wrapper still uses
reporter.sendTelemetryEvent() in the error path which is incompatible with
@vscode/extension-telemetry v0.8.0+; change the wrapper so that normal events
still use sendTelemetryEvent but error reporting uses the new
sendTelemetryErrorEvent API: update imports/types if needed, add a dedicated
sendError wrapper function that maps error properties to the new API signature
(include message, properties, and measures), and keep a runtime-safe fallback to
sendTelemetryEvent for older versions if sendTelemetryErrorEvent is undefined.
Ensure callers of the wrapper use the new sendError wrapper or that the existing
error-path calls are routed to it.
This PR contains the following updates:
^0.7.7->^0.9.0Release Notes
Microsoft/vscode-extension-telemetry (@vscode/extension-telemetry)
v0.9.9Compare Source
Changes:
This list of changes was auto generated.
v0.9.8Compare Source
Changes:
This list of changes was auto generated.
v0.9.7Compare Source
Changes:
This list of changes was auto generated.
v0.9.6Compare Source
v0.9.5Compare Source
v0.9.4: Align measurements with propertiesCompare Source
v0.9.3: Improved user agentCompare Source
navigator.userAgentDatais unavailable. Thanks to @seznav0.9.2: Global Privacy Control compliance fixesCompare Source
This release contains a small fix to the 1DS package used by Microsoft extensions in the web to ensure compliance with the California's Global Privacy Control. If you're not a Microsoft extension, then it is safe to disregard this release as it contains no new features or improvements for the third party flow.
v0.9.1: Fixunhandlederrorcommon props.Compare Source
Thanks to a community contribution by @ilia-db the
unhandlederrorevent handler has been properly fixed to include common properties.v0.9.0: Use app insights basics versus the complete app insights package to reduce bundle sizeCompare Source
Application insights web basics comes with the ability to pass in a fetch pollyfill that allows it to be used for both Node and Web. This is similar to what we already do for first party extensions using the 1DS package.
While there is no breaking changes here, the replacement of a key dependency with what should be an equivalent alternative may have unknown edge cases that were not accounted for, therefore the version has been bumped to reflect this.
Bundlephobia reports a 67Kb decline in bundle size with this change.
v0.8.5: Improve shutdown performanceCompare Source
v0.8.4: Fix data loss on connection lossCompare Source
sendRawTelemetryEventsendingkey: keypairs instead ofkey: valuepairsv0.8.3Compare Source
v0.8.2: Fix missingsendRawTelemetryEventfunction + Dependency updatesCompare Source
sendRawTelemetryEventfunction which was missing in the implementation, but defined in the.d.tsv0.8.1: Better teardown + error handlingCompare Source
This release only contains bug fixes
sendErrorDatafunction microsoft#158v0.8.0: Better align telemetry reporters across desktop and webCompare Source
Note: This release contains a breaking change to the typings.
The ability to log a raw
Errorobject has been removed. You will now have to usesendTelemetryErrorEventand break the error stack down into the properties you want due to the web app insights and 1DS library both not supporting this. We want the module to abstract the details away and offer a uniform experience across all platforms.Also fixes a bug surrounding not logging events properly on shutdown.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit