Path problems on Windows

[gtflip]

Since it uses path.join in several places, on Windows it creates a path string with backslashes in it instead of slashes. This doesn't work as expected for an AWS S3 key (the only module I've tested with so far). I changed a few imports from "node:path" to "node:path/posix", which allowed me to use it on Windows.

I got it compiling from github on Windows using cross-env and fse-cli, but obviously I don't have access to your S3 bucket for testing, e.g., so I stopped working on that for now.

[frankdejonge]

Cheers, I'll look into this.

[frankdejonge]

I've just pushed a change that swaps the normal path functions for the posix kind. It's injected in, so the other adapters keep working too.

[frankdejonge]

@gtflip a new version is out which I hope addresses this. Could you verify?

[gtflip]

Unfortunately not. It's happening in PathNormalizerV1.normalizePath and PathPrefixer. I changed my copies in node_modules to do import { join } from 'node:path/posix'; and that worked for my S3 tests. I don't know if that fits in with the way you want to do things.

I just use FileStorage.read() and FileStorage.stat() right now, though, so it's not a full test.

[gtflip]

I got testing running on my Windows system. Looks like it's not a simple fix for local-fs. I'll see if I can get those two working on Windows.

[frankdejonge]

We'll have to make sure that CI is also able to validate the implementation. I'll try to see if I can mooch off some prior art somewhere.

Hey ;) Any progress on this one? As we just hit the same problem which makes the library basically unusable on windows

[frankdejonge]

I haven't found a good reference project to model github actions on for windows. If you have suggestions I'm happy to spend time on it to set it up

[akrolasik-bc]

In Unix file systems, the path separator is the forward slash (/). In Amazon S3, object keys also use the forward slash (/) to simulate a hierarchical structure similar to a file system. However, it's important to understand that there is no direct dependency between the Unix file system path separator and the S3 object key separator.

S3 is an object storage service, and it doesn't actually have a file system hierarchy. The forward slash in S3 object keys is simply a convention used to organize objects in a way that resembles directories, for easier human readability and management through tools like the S3 console.

When you're working with S3 in a Unix environment, using tools or scripts, you will likely use the Unix path separator to organize or manage files locally, and then convert or maintain similar structures when uploading to S3 by using the forward slash in object keys. Nevertheless, this is a matter of convention and convenience, rather than a strict dependency enforced by the systems.

I would sugest adding a conversion between prefixed file path and s3 key.

[frankdejonge]

How about something like this: #93

[UlisesGallardo]

any update on this?