Issue Report: phpsaml Plugin Not Functioning After GLPi Update to Version 10.0.11

[santanaalmeida91]

I am writing to bring to your attention an issue I have encountered with the phpsaml plugin in GLPi.

After updating GLPi to version 10.0.11, the phpsaml plugin seems to have stopped functioning correctly. When attempting to access my GLPi the screen becomes unresponsive (/plugins/phpsaml/front/acs.php), and the expected redirection to the GLPi home page does not occur.

I have thoroughly tested this behavior and can confirm that the issue is consistent after the upgrade to GLPi 10.0.11. It appears to be isolated to the phpsaml plugin, as other functionalities within GLPi remain unaffected.

Thank you for your time and assistance in resolving this matter. I look forward to hearing from you soon.

[SilvaFernando]

Hi @DonutsNL and @derricksmith.

Can you help us?

I think this is a bus when includes.php tries to read the POST variable on acs.php, look:

glpiphplog.WARNING:   *** PHP Warning (2): Undefined global variable $_POST in /usr/share/glpi/inc/includes.php at line 102
  Backtrace :
  plugins/phpsaml/front/acs.php:12                   include()
  public/index.php:82                                require()

[NateTL]

I am also experiencing problems with the plugin with 11.0.11 except my issue is with the initial configuration of the plugin within GLPI. After I fill in all of the Identity Provider Configuration settings and click "update" the screen refreshes with all of the settings removed and an error message at the top which says "Error updating settings. Review field values.". This is my first deployment of GLPI and everything else seems to be working fine but I can't get the phpsaml plugin settings to be saved. Thanks.

[DonutsNL]

I will dive into this comming weekend. If you can share logging and the exact version you are using... that would be instrumental. Rgrds

[NateTL]

Not sure if you are asking me or the others. I am running GLPI 11.0.11 on Ubuntu and 1.2.1 of phpsaml. What logging would you like to see? I'm off on holiday until Jan 8th after today so I might not be able to respond before then. Thanks for looking into this.

[DonutsNL]

Please use the latest version from my repository. That version is way ahead of this one and has various bugfixes. Derrick has been away for some time yet and had not yet reviewed the pull request and he still needs to merge the versions.

https://github.com/DonutsNL/phpsaml

[NateTL]

Thanks - my bad. Didn't realize that I didn't pickup the latest version. Will give that a try today.

[efriastech]

Hi DonutsNL, first I want to thank you for keeping this plugin updated on your branch and hope it gets merged.
I also have the same issue after updating GLPI and PHP. I am using your latest version.

It was working fine on GLPI 10.0.10 with PHP 8.0.

I have now updated to GLPI 10.0.11 and also to PHP 8.1 and seem to be redirected to:
https://glpi.example.com/plugins/phpsaml/front/acs.php with a white page.

(I have also tested with GLPI 10.0.11 but with PHP 8.0 and have the same results. It appears that the only variable here is GLPI 10.0.11.)

My php-error.log also mentions an issue (PHP 8.0 and PHP 8.1), somewhat different to what SilvaFernando showed previously:

[2023-12-20 20:18:12] glpiphplog.CRITICAL:   
*** Uncaught Exception TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given in /var/www/html/10.0.11/glpi/inc/includes.php at line 102
  Backtrace :
  plugins/phpsaml/front/acs.php:6                    include()

---------------------
Operating System: Oracle Linux Server 8.9
Kernel: Linux 4.18.0-513.5.1.el8_9.x86_64
Server version: Apache/2.4.37 (Oracle Linux)
PHP 8.1.27 (cli) (built: Dec 19 2023 20:35:55) (NTS gcc x86_64)
mysql  Ver 15.1 Distrib 10.6.16-MariaDB
---------------------

I leave this here in the hope it sheds more light into the issue. I'm willing to provide more information, if necessary.

[NateTL]

I echo Emanuel's thanks for your work on this very useful plugin. It's pretty much a requirement for us to be able to roll out GLPI at my company.
I'm seeing a couple missing field descriptions and missing dropdown list on the second missing field description. Also, have a warning message "Phpsaml expected 21 configuration items but got 19 items instead triggered update" showing. See attached screenshot for more details.
It could be due to these missing config values but when I attempt to logon via PHP SAML it fails with the following message from Microsoft:

Request Id: 2e4cff13-1922-4ada-bd16-cb0b56185300
Correlation Id: 3f9cb68d-333f-4bf1-bdef-77fdad0254fd
Timestamp: 2023-12-20T21:01:49Z
Message: AADSTS7500522: XML element 'AuthnContextClassRef' in XML namespace 'urn:oasis:names:tc:SAML:2.0:assertion' in the SAML message must be a URI.

Whenever this happens I see the following in the php-errors.log file:

[2023-12-20 21:06:03] glpiphplog.WARNING: *** PHP Warning (2): Undefined array key "proxied" in /var/www/html/glpi/plugins/phpsaml/inc/phpsaml.class.php at line 190
Backtrace :
plugins/phpsaml/inc/phpsaml.class.php:424 PluginPhpsamlPhpsaml::auth()
plugins/phpsaml/inc/phpsaml.class.php:271 PluginPhpsamlPhpsaml::ssoRequest()
plugins/phpsaml/setup.php:203 PluginPhpsamlPhpsaml->processUserLogin()
src/Plugin.php:1696 pluginPhpsamlPostInit()
src/Plugin.php:276 Plugin::doHook()
inc/includes.php:98 Plugin->init()
index.php:87 include()

Thanks!

[SilvaFernando]

Hi @DonutsNL.
I've tested using you plugin version and I have same problem :(

[SilvaFernando]

Hi @DonutsNL again rsrs

In my test environment, was copied the GLPI file inc/includes.php from the 10.0.10 version, I think this is not the best way, but maybe this can be a starting point for you.

[DonutsNL]

Yes the column check indicates that for what ever reason an older version of the database schema is present. it is not updated correctly. This is a known bug that i havent addressed yet. Please backup the configuration and fully reinstall the latest version. If there is still an error, please review the /glpi/files/_log/ errorlog.

Ill try to review any errors this weekend and publish a new version if required

[SilvaFernando]

I tried to change the way acs.php calls inc/includes.php, but I'm not a dev and I couldn't find it.

I've already tried reinstalling and the error doesn't change, maybe it's a very annoying bug.

[DonutsNL]

There should be an error in the GLPI/files/_log/phperror log. Could you review it and share any strange errors triggered within the phpsaml directory?

[SilvaFernando]

Unfornately not, just this:
*** PHP Warning (2): Undefined global variable $_POST in /usr/share/glpi/inc/includes.php at line 102
Backtrace :
plugins/phpsaml/front/acs.php:12 include()
public/index.php:82 require()

[sblanchouin]

Hi, same thing here, I just updated the plugin from your repository. Here the log, when the white screen appear.

[2023-12-22 14:19:08] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given in /var/www/html/glpi/inc/includes.php at line 102
Backtrace :
plugins/phpsaml/front/acs.php:6 include()
public/index.php:82 require()