Skip to content

Commit 677eed2

Browse files
committed
Rename ideUrl to mainUrl
Since not all DevWorkspaces contain IDEs, it makes more sense to use a generic name rather than the IDE-specific language. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
1 parent ff3c01b commit 677eed2

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/apis/workspaces/v1alpha1/conversion.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
func convertDevWorkspaceTo_v1alpha2(src *DevWorkspace, dest *v1alpha2.DevWorkspace) error {
88
dest.ObjectMeta = src.ObjectMeta
99
dest.Status.DevWorkspaceId = src.Status.WorkspaceId
10-
dest.Status.IdeUrl = src.Status.IdeUrl
10+
dest.Status.MainUrl = src.Status.IdeUrl
1111
dest.Status.Phase = v1alpha2.DevWorkspacePhase(src.Status.Phase)
1212
dest.Status.Message = src.Status.Message
1313
convertConditionsTo_v1alpha2(src, dest)
@@ -20,7 +20,7 @@ func convertDevWorkspaceTo_v1alpha2(src *DevWorkspace, dest *v1alpha2.DevWorkspa
2020
func convertDevWorkspaceFrom_v1alpha2(src *v1alpha2.DevWorkspace, dest *DevWorkspace) error {
2121
dest.ObjectMeta = src.ObjectMeta
2222
dest.Status.WorkspaceId = src.Status.DevWorkspaceId
23-
dest.Status.IdeUrl = src.Status.IdeUrl
23+
dest.Status.IdeUrl = src.Status.MainUrl
2424
dest.Status.Phase = WorkspacePhase(src.Status.Phase)
2525
dest.Status.Message = src.Status.Message
2626
convertConditionsFrom_v1alpha2(src, dest)

pkg/apis/workspaces/v1alpha2/devworkspace_types.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ type DevWorkspaceSpec struct {
1616
type DevWorkspaceStatus struct {
1717
// Id of the DevWorkspace
1818
DevWorkspaceId string `json:"devworkspaceId"`
19-
// URL at which the DevWorkspace Editor can be joined
20-
IdeUrl string `json:"ideUrl,omitempty"`
21-
Phase DevWorkspacePhase `json:"phase,omitempty"`
19+
// Main URL for this DevWorkspace
20+
MainUrl string `json:"mainUrl,omitempty"`
21+
Phase DevWorkspacePhase `json:"phase,omitempty"`
2222
// Conditions represent the latest available observations of an object's state
2323
Conditions []DevWorkspaceCondition `json:"conditions,omitempty"`
2424
// Message is a short user-readable message giving additional information

0 commit comments

Comments
 (0)