Skip to content

Commit 551b4f5

Browse files
committed
chore: simplify threeDotsDropdownItems binding in multiple views for improved readability and consistency
1 parent 2303968 commit 551b4f5

File tree

5 files changed

+5
-15
lines changed

5 files changed

+5
-15
lines changed

adminforth/spa/src/components/ThreeDotsMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
id="listThreeDotsDropdown"
1515
class="z-20 hidden bg-lightThreeDotsMenuBodyBackground divide-y divide-gray-100 rounded-lg shadow w-44 dark:bg-darkThreeDotsMenuBodyBackground dark:divide-gray-600">
1616
<ul class="py-2 text-sm text-lightThreeDotsMenuBodyText dark:text-darkThreeDotsMenuBodyText" aria-labelledby="dropdownMenuIconButton">
17-
<li v-for="item in threeDotsDropdownItems" :key="`dropdown-item-${item.file}`">
17+
<li v-for="(item, i) in threeDotsDropdownItems" :key="`dropdown-item-${i}`">
1818
<a href="#"
1919
class="block px-4 py-2 hover:bg-lightThreeDotsMenuBodyBackgroundHover hover:text-lightThreeDotsMenuBodyTextHover dark:hover:bg-darkThreeDotsMenuBodyBackgroundHover dark:hover:text-darkThreeDotsMenuBodyTextHover"
2020
:class="{

adminforth/spa/src/views/CreateView.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@
3131
</button>
3232

3333
<ThreeDotsMenu
34-
:threeDotsDropdownItems="Array.isArray(coreStore.resourceOptions?.pageInjections?.create?.threeDotsDropdownItems)
35-
? coreStore.resourceOptions?.pageInjections?.create?.threeDotsDropdownItems
36-
: coreStore.resourceOptions?.pageInjections?.create?.threeDotsDropdownItems
37-
? [coreStore.resourceOptions?.pageInjections?.create?.threeDotsDropdownItems]
38-
: []"
34+
:threeDotsDropdownItems="(coreStore.resourceOptions?.pageInjections?.create?.threeDotsDropdownItems as [])"
3935
></ThreeDotsMenu>
4036

4137
</BreadcrumbsWithButtons>

adminforth/spa/src/views/EditView.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@
2727
</button>
2828

2929
<ThreeDotsMenu
30-
:threeDotsDropdownItems="Array.isArray(coreStore.resourceOptions?.pageInjections?.edit?.threeDotsDropdownItems)
31-
? coreStore.resourceOptions.pageInjections.edit.threeDotsDropdownItems
32-
: coreStore.resourceOptions?.pageInjections?.edit?.threeDotsDropdownItems
33-
? [coreStore.resourceOptions.pageInjections.edit.threeDotsDropdownItems]
34-
: undefined"
30+
:threeDotsDropdownItems="(coreStore.resourceOptions?.pageInjections?.edit?.threeDotsDropdownItems as [])"
3531
></ThreeDotsMenu>
3632

3733
</BreadcrumbsWithButtons>

adminforth/spa/src/views/ListView.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,7 @@
9090
</button>
9191

9292
<ThreeDotsMenu
93-
:threeDotsDropdownItems="coreStore.resourceOptions?.pageInjections?.list?.threeDotsDropdownItems
94-
? ([] as any[]).concat(coreStore.resourceOptions.pageInjections.list.threeDotsDropdownItems)
95-
: []"
93+
:threeDotsDropdownItems="(coreStore.resourceOptions?.pageInjections?.list?.threeDotsDropdownItems as [])"
9694
:bulkActions="coreStore.resource?.options?.bulkActions"
9795
:checkboxes="checkboxes"
9896
@startBulkAction="startBulkAction"

adminforth/spa/src/views/ShowView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
</button>
5050

5151
<ThreeDotsMenu
52-
:threeDotsDropdownItems="coreStore.resourceOptions?.pageInjections?.show?.threeDotsDropdownItems"
52+
:threeDotsDropdownItems="(coreStore.resourceOptions?.pageInjections?.show?.threeDotsDropdownItems as [])"
5353
:customActions="customActions"
5454
></ThreeDotsMenu>
5555
</BreadcrumbsWithButtons>

0 commit comments

Comments
 (0)