Use new api calls which support RTCError

Author: devopvoid

webrtc-jni/src/main/cpp/src/JNI_PeerConnectionFactory.cpp

@@ -24,6 +24,7 @@
 #include "JavaError.h"
 #include "JavaFactories.h"
 #include "JavaNullPointerException.h"
+#include "JavaRuntimeException.h"
 #include "JavaRef.h"
 #include "JavaString.h"
 #include "JavaUtils.h"
@@ -219,7 +220,16 @@ JNIEXPORT jobject JNICALL Java_dev_onvoid_webrtc_PeerConnectionFactory_createPee
 	webrtc::PeerConnectionObserver * observer = new jni::PeerConnectionObserver(env, jni::JavaGlobalRef<jobject>(env, jobserver));
 	webrtc::PeerConnectionDependencies dependencies(observer);
 
-	auto pc = factory->CreatePeerConnection(configuration, std::move(dependencies));
+	auto result = factory->CreatePeerConnectionOrError(configuration, std::move(dependencies));
+
+	if (!result.ok()) {
+		env->Throw(jni::JavaRuntimeException(env, "Create PeerConnection failed: %s %s",
+			ToString(result.error().type()), result.error().message()));
+
+		return nullptr;
+	}
+
+	auto pc = result.MoveValue();
 
 	if (pc != nullptr) {
 		auto javaPeerConnection = jni::JavaFactories::create(env, pc.release());

webrtc-jni/src/main/cpp/src/JNI_RTCPeerConnection.cpp

@@ -206,7 +206,16 @@ JNIEXPORT jobject JNICALL Java_dev_onvoid_webrtc_RTCPeerConnection_createDataCha
 	webrtc::DataChannelInit dict = jni::RTCDataChannelInit::toNative(env, jni::JavaLocalRef<jobject>(env, jDict));
 
 	try {
-		auto dataChannel = pc->CreateDataChannel(label, &dict);
+		auto result = pc->CreateDataChannelOrError(label, &dict);
+
+		if (!result.ok()) {
+			env->Throw(jni::JavaRuntimeException(env, "Create DataChannel failed: %s %s",
+				ToString(result.error().type()), result.error().message()));
+
+			return nullptr;
+		}
+
+		auto dataChannel = result.MoveValue();
 
 		return jni::JavaFactories::create(env, dataChannel.release()).release();
 	}

webrtc-jni/src/main/cpp/src/JNI_RTCRtpTransceiver.cpp

@@ -21,6 +21,7 @@
 #include "JavaFactories.h"
 #include "JavaList.h"
 #include "JavaRef.h"
+#include "JavaRuntimeException.h"
 #include "JavaString.h"
 #include "JavaUtils.h"
 #include "WebRTCUtils.h"
@@ -73,7 +74,12 @@ JNIEXPORT void JNICALL Java_dev_onvoid_webrtc_RTCRtpTransceiver_setDirection
 	webrtc::RtpTransceiverInterface * transceiver = GetHandle<webrtc::RtpTransceiverInterface>(env, caller);
 	CHECK_HANDLE(transceiver);
 
-	transceiver->SetDirection(jni::JavaEnums::toNative<webrtc::RtpTransceiverDirection>(env, jDirection));
+	webrtc::RTCError result = transceiver->SetDirectionWithError(jni::JavaEnums::toNative<webrtc::RtpTransceiverDirection>(env, jDirection));
+
+	if (!result.ok()) {
+		env->Throw(jni::JavaRuntimeException(env, "Set direction failed: %s %s",
+			ToString(result.type()), result.message()));
+	}
 }
 
 JNIEXPORT jobject JNICALL Java_dev_onvoid_webrtc_RTCRtpTransceiver_getCurrentDirection
@@ -97,7 +103,12 @@ JNIEXPORT void JNICALL Java_dev_onvoid_webrtc_RTCRtpTransceiver_stop
 	webrtc::RtpTransceiverInterface * transceiver = GetHandle<webrtc::RtpTransceiverInterface>(env, caller);
 	CHECK_HANDLE(transceiver);
 
-	transceiver->Stop();
+	webrtc::RTCError result = transceiver->StopStandard();
+
+	if (!result.ok()) {
+		env->Throw(jni::JavaRuntimeException(env, "Stop transceiver failed: %s %s",
+			ToString(result.type()), result.message()));
+	}
 }
 
 JNIEXPORT jboolean JNICALL Java_dev_onvoid_webrtc_RTCRtpTransceiver_stopped