Skip to content

Add styling BOLD_RESET_FG (black un Jupyter Lab, white un VSCode) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrus merged 1 commit into from
Dec 29, 2024
Merged

Add styling BOLD_RESET_FG (black un Jupyter Lab, white un VSCode) #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jjava/src/main/java/org/dflib/jjava/JavaKernel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ public JavaKernel(String version) {
);

this.errorStyler = new StringStyler.Builder()
.addPrimaryStyle(TextColor.BOLD_BLACK_FG)
.addPrimaryStyle(TextColor.BOLD_RESET_FG)
.addSecondaryStyle(TextColor.BOLD_RED_FG)
.addHighlightStyle(TextColor.BOLD_BLACK_FG)
.addHighlightStyle(TextColor.BOLD_RESET_FG)
.addHighlightStyle(TextColor.RED_BG)
//TODO map snippet ids to code cells and put the proper line number in the margin here
.withLinePrefix(TextColor.BOLD_BLACK_FG + "| ")
.withLinePrefix(TextColor.BOLD_RESET_FG + "| ")
.build();

this.mavenResolver.initImplicitExtensions();
Expand Down
4 changes: 2 additions & 2 deletions jupyter-jvm-basekernel/src/main/java/org/dflib/jjava/jupyter/kernel/BaseKernel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ public BaseKernel(Charset charset) {
Text.registerAll(this.renderer);

this.errorStyler = new StringStyler.Builder()
.addPrimaryStyle(TextColor.BOLD_BLACK_FG)
.addPrimaryStyle(TextColor.BOLD_RESET_FG)
.addSecondaryStyle(TextColor.BOLD_RED_FG)
.addHighlightStyle(TextColor.BOLD_BLACK_FG)
.addHighlightStyle(TextColor.BOLD_RESET_FG)
.addHighlightStyle(TextColor.RED_BG)
.build();
}
Expand Down
2 changes: 2 additions & 0 deletions jupyter-jvm-basekernel/src/main/java/org/dflib/jjava/jupyter/kernel/util/TextColor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public enum TextColor {
WHITE_BG(47),
RESET_BG(49),

BOLD_RESET_FG(39, 1),

BOLD(1),
UNDERLINE(4),
SWAP_FG_BG(7),
Expand Down
Loading