Enriching with TraceActivityAttribute

[knightfall]

Hi,
I came here from the blog post Using the Decorator Pattern to Auto-Instrument .Net Classes With Otel Tracing.
I found it while searching for a solution to access custom attributes of methods when using DispatchProxy.
In DispatchProxy Invoke, the methodinfo's custom attributes are always null if the custom attributes are in the methods of the class, not the interface.
I am wondering if I am missing something. I have tried to use Digma's TraceDecorator code to test and got the same behaviour.

[doppleware]

Hey @knightfall thanks for trying this out!
Can you post a code sample? It should work with attributes on the class method and our tests are actually running that scenario so it would be interesting to see what the difference is in your use case.

Thanks!
Roni

[knightfall]

Hi @doppleware ,
Here is the project that I have created as a sample with minimal configuration: Otel_TestBed

Here is the trace output in console:
Activity.TraceId: 8da91c4251ad353129b952a38c800434 Activity.SpanId: 890adbad5b34d710 Activity.TraceFlags: Recorded Activity.ParentSpanId: d95a457561c7d190 Activity.ActivitySourceName: Otel_TestBed.SampleService Activity.DisplayName: LowLevelRandomTryCatch Activity.Kind: Internal Activity.StartTime: 2023-03-20T10:20:58.9464527Z Activity.Duration: 00:00:00.0024885 Activity.Tags: code.namespace: Otel_TestBed.SampleService code.function: LowLevelRandomTryCatch code.function.parameter.types: Resource associated with Activity: telemetry.sdk.name: opentelemetry telemetry.sdk.language: dotnet telemetry.sdk.version: 1.4.0.802 service.name: otel-test service.version: 0.01a service.instance.id: 63d6c47a-8e90-499e-8752-80b84490d9d6

I have checked the test methods, and I don't there is a test to check for additional tags in there.

for my project, I am getting the method info from the decorated class to get the custom attributes:
_decorated.GetType().GetMethod(targetMethod.Name, args.Select(x => x.GetType()).ToArray())
While it works for most of my use cases, I think it is slower, and currently, it fails for some complex parameters
Thanks,
Sazid

[doppleware]

You are right! It seems like an issue in the Proxy implementation.
I'll look at the right solution, in the meanwhile, notice you can also use the ActivitiesAttributes method on the class level (which does work)

[knightfall]

I am currently checking the viability of using attributes on the interface methods. Not ideal, but it works.
Also, I am going to create an issue under dotnet/runtime and see if we are missing something

[doppleware]

Hey @knightfall just created #20 to fix this issue.
I did use something similar to what you suggested but added some caching so any performance hit should not be felt beyond the first call. Fixed a few more bugs. Hope to merge after review soon.

[knightfall]

Hi @doppleware ,
Checked #20. Good stuff with the caching. Didn't think of it. But c# _decorated.GetType().GetMethod(targetMethod.Name)?.GetCustomAttribute<TAttribute>(inherit:true) will fail when a method is overloaded with this exception: System.Reflection.AmbiguousMatchException: Ambiguous match found. Here is an example with overloaded method